[GitHub] [cassandra] dcapwell commented on a change in pull request #730: CASSANDRA-16082 - Add a new jmxtool which can dump what JMX objects exist and diff

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #730:
URL: https://github.com/apache/cassandra/pull/730#discussion_r480267168



##########
File path: test/unit/org/apache/cassandra/tools/ToolRunner.java
##########
@@ -75,13 +77,6 @@ public ToolRunner(List<String> args, boolean runOutOfProcess)
         this.runOutOfProcess = runOutOfProcess;
     }
 
-    public ToolRunner withStdin(InputStream stdin, boolean autoClose)

Review comment:
       it was dead code and harder to reason how to deal with.  There are two patterns I see with stdin: one time input, and interactive; the interactive case seems hard to deal with if creating a thread to try to copy bytes.  Normally I see stdin exposed so the test can control when bytes are added, so would expect something like
   
   ```class ToolRunner {
   ...
   OutputStream getStdin()
   ...```. and then the test can append to stdin when desired.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org