[lucene-solr] branch reference_impl_dev updated: @1022 Whoops, revert this - issue ended up being no response parser that had json as string.

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl_dev by this push:
     new 080efd2  @1022 Whoops, revert this - issue ended up being no response parser that had json as string.
080efd2 is described below

commit 080efd271bbb8bb427f3d77c2396d5abf4e4934c
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sat Oct 17 15:23:09 2020 -0500

    @1022 Whoops, revert this - issue ended up being no response parser that had json as string.
---
 .../java/org/apache/solr/client/solrj/impl/Http2SolrClient.java    | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java b/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java
index f1701e3..ba4861d 100644
--- a/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java
+++ b/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java
@@ -823,6 +823,10 @@ public class Http2SolrClient extends SolrClient {
 
       Object error = rsp == null ? null : rsp.get("error");
 
+      if (error != null) {
+        throw RemoteExecutionException.create(serverBaseUrl, rsp);
+      }
+
       if (httpStatus != HttpStatus.SC_OK && !isV2Api) {
         NamedList<String> metadata = null;
         String reason = null;
@@ -860,9 +864,6 @@ public class Http2SolrClient extends SolrClient {
         throw rss;
       }
 
-      if (error != null) {
-        throw RemoteExecutionException.create(serverBaseUrl, rsp);
-      }
       return rsp;
     } finally {
       if (shouldClose) {