You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "contrueCT (via GitHub)" <gi...@apache.org> on 2025/12/09 16:30:53 UTC
[PR] fix: resolve TransactionAutoConfiguration compatibility with Spring Boot 4.x [incubator-seata]
contrueCT opened a new pull request, #7839:
URL: https://github.com/apache/incubator-seata/pull/7839
…on compatibility
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [x] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [x] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
This PR resolves the Spring Boot 4.x compatibility issue caused by the relocation of TransactionAutoConfiguration. I modified SeataSpringFenceAutoConfiguration to replace the hard import with string-based class names in the @AutoConfigureAfter annotation. By including both the legacy (Spring Boot 2.x/3.x) and new (Spring Boot 4.x) package paths, this approach ensures full backward compatibility and prevents compilation errors, consistent with the existing implementation in SeataDataSourceAutoConfiguration.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixed #7805
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: resolve TransactionAutoConfiguration compatibility with Spring Boot 4.x [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7839:
URL: https://github.com/apache/incubator-seata/pull/7839#issuecomment-3633243672
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7839?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 70.98%. Comparing base ([`891ca5d`](https://app.codecov.io/gh/apache/incubator-seata/commit/891ca5dbbe422e97f1fff35b52b2eec4594a00a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`203cdf0`](https://app.codecov.io/gh/apache/incubator-seata/commit/203cdf0e54ae62aaf698bf02e3c27ea55e843be8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7839 +/- ##
============================================
+ Coverage 70.93% 70.98% +0.05%
Complexity 992 992
============================================
Files 1322 1322
Lines 50322 50322
Branches 5946 5946
============================================
+ Hits 35697 35723 +26
+ Misses 11680 11651 -29
- Partials 2945 2948 +3
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7839?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...toconfigure/SeataSpringFenceAutoConfiguration.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7839?src=pr&el=tree&filepath=seata-spring-autoconfigure%2Fseata-spring-autoconfigure-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fspring%2Fboot%2Fautoconfigure%2FSeataSpringFenceAutoConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VhdGEtc3ByaW5nLWF1dG9jb25maWd1cmUvc2VhdGEtc3ByaW5nLWF1dG9jb25maWd1cmUtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9zcHJpbmcvYm9vdC9hdXRvY29uZmlndXJlL1NlYXRhU3ByaW5nRmVuY2VBdXRvQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7839/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: resolve TransactionAutoConfiguration compatibility with Spring Boot 4.x [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #7839:
URL: https://github.com/apache/incubator-seata/pull/7839#issuecomment-3634963176
Please run mvn spotless:apply on your local machine to automatically reformat any classes that don't comply with the project's code style, then commit and push the resulting changes to this pull request. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: resolve TransactionAutoConfiguration compatibility with Spring Boot 4.x [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #7839:
URL: https://github.com/apache/incubator-seata/pull/7839#issuecomment-3634957888
请将你的钉钉号发到我的邮件中，我将邀请你加入seata贡献者群中
Please send your DingTalk ID to my email, and I will invite you to join the Seata contributors group
jianbin@apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: resolve TransactionAutoConfiguration compatibility with Spring Boot 4.x [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #7839:
URL: https://github.com/apache/incubator-seata/pull/7839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: resolve TransactionAutoConfiguration compatibility with Spring Boot 4.x [incubator-seata]
Posted by "contrueCT (via GitHub)" <gi...@apache.org>.
contrueCT commented on PR #7839:
URL: https://github.com/apache/incubator-seata/pull/7839#issuecomment-3633244121
<img width="2560" height="1380" alt="image" src="https://github.com/user-attachments/assets/af9e98af-29fb-474f-9d54-74052fa535d1" />
The Spotless check failed in the seata-config-core module, but I haven't modified any files in that directory. I tried running mvn spotless:apply locally, but it resulted in no changes. This seems to be unrelated to my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org