[jira] [Commented] (TS-4280) Refactor gzip plugin to eliminate memory leak and reduce global hooks

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207388#comment-15207388 ] 

ASF GitHub Bot commented on TS-4280:
------------------------------------

GitHub user zwoop opened a pull request:

    https://github.com/apache/trafficserver/pull/534

    TS-4280 Refactors the gzip plugin to improve hooks and memory usage

    This accomplishes three things:
    
    1) Fix memory leak on config reload (ref-counting)
    
    2) Reduces the number of global hooks, which then
    
    3) Allows to eliminate the usage of all TXN data slots

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zwoop/trafficserver TS-4280

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #534
    
----

----


> Refactor gzip plugin to eliminate memory leak and reduce global hooks
> ---------------------------------------------------------------------
>
>                 Key: TS-4280
>                 URL: https://issues.apache.org/jira/browse/TS-4280
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 6.2.0
>
>
> I'd like to achieve three things with this refactoring:
> 1) Reduce the number of global hooks (this makes TS-4147 nicer)
> 2) Eliminate all use of TXN data slots (it now uses 3, which is very excessive, and we can get away with using none, thanks to 1) ).
> 3) Fix the memory leaks on configuration reloads, by ref-counting the HostConfiguration's properly through the TXN's lifetime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)