You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by James Turner <tu...@blackbear.com> on 2003/05/13 18:13:45 UTC
1.1 RC2 status (was RE: [VOTE] Product Change: Replace DBPC/Pool with original GDS)
Well, one of them is a web site bug, one of them seems to be a non-bug
pending a reply from the user, I just commited a patch for one of them
and the other one is (IMO) a WONT-FIX, so we're left with a compilation
issue with the taglib tests in JDK 1.4.
James
> -----Original Message-----
> From: David Graham [mailto:dgraham1980@hotmail.com]
> Sent: Tuesday, May 13, 2003 11:39 AM
> To: struts-dev@jakarta.apache.org
> Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with
> original GDS, distributed in separate JAR
>
>
> I think FileUpload is the last dependency (there are 2 open
> bugs against
> it). We also need to handle the 4 remaining Struts bugs.
>
> David
>
>
> >From: "James Turner" <tu...@blackbear.com>
> >Reply-To: "Struts Developers List" <st...@jakarta.apache.org>
> >To: "'Struts Developers List'" <st...@jakarta.apache.org>
> >Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with original
> >GDS,
> >distributed in separate JAR
> >Date: Tue, 13 May 2003 11:30:48 -0400
> >
> >So the vote was pretty unanimous in doing this, has it been
> done, and
> >if so, is it true that we're just waiting for FileUpload to
> go gold to
> >do RC2?
> >
> >James
> >
> > > -----Original Message-----
> > > From: dmkarr@wondark.www.rattieworldocomfort.com
> > > [mailto:dmkarr@wondark.www.rattieworldocomfort.com] On Behalf Of
> > > David M. Karr
> > > Sent: Sunday, May 11, 2003 2:47 AM
> > > To: struts-dev@jakarta.apache.org
> > > Subject: Re: [VOTE] Product Change: Replace DBPC/Pool
> with original
> > > GDS, distributed in separate JAR
> > >
> > >
> > > >>>>> "Ted" == Ted Husted <hu...@apache.org> writes:
> > >
> > > Ted> The source for the GDS has already been uploaded as an
> > > independent
> > > Ted> package under contrib (struts-legacy). I would
> like to change
> > > Ted> util.GenericDataSource to wrap this class instead of the
> > > DBCP, and
> > > Ted> eliminate our dependencies on DBCP and Commons-Pool.
> > >
> > > Ted> Votes or discussion, please?
> > >
> > > I'll +1 this also, although I think the name (struts-legacy) is a
> > > little odd. Call it what it is. However, it's not worth arguing
> > > about.
> > >
> > > --
> > >
> ===================================================================
> > > David M. Karr ; Java/J2EE/XML/Unix/C++
> > > dmkarr@earthlink.net ; SCJP; SCWCD
> > >
> > >
> > >
> > >
> > >
> --------------------------------------------------------------------
> > > -
> > > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail:
> struts-dev-help@jakarta.apache.org
> > >
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
>
> _________________________________________________________________
> The new MSN 8: smart spam protection and 2 months FREE*
> http://join.msn.com/?page=features/junkmail
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace DBPC/Pool with original GDS)
Posted by James Mitchell <jm...@apache.org>.
Thanks James, I appreciate your help. I feel like a grounded pilot without
my DSL.
--
James Mitchell
Software Developer/Struts Evangelist
http://www.open-tools.org
----- Original Message -----
From: "James Turner" <tu...@blackbear.com>
To: "'Struts Developers List'" <st...@jakarta.apache.org>
Sent: Tuesday, May 13, 2003 2:24 PM
Subject: RE: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace
DBPC/Pool with original GDS)
Commited, which brings us down to one bug that may not be a bug, and a
web site fix. So it's all about FileUpload now...
James
> -----Original Message-----
> From: James Mitchell [mailto:jmitchell@apache.org]
> Sent: Tuesday, May 13, 2003 1:54 PM
> To: Struts Developers List
> Subject: Re: 1.1 RC2 status (was RE: [VOTE] Product Change:
> Replace DBPC/Pool with original GDS)
>
>
> I believe I wrote most of those and did not realize it was a
> 1.4 only call.....sorry.
>
> I'm planning to rewrite most of those tests anyway, so could
> someone just go ahead and commit it (I can't do it myself
> until I get my dsl back up).
>
> Thanks in advance.
>
> --
> James Mitchell
> Software Developer/Struts Evangelist
> http://www.open-tools.org
>
>
>
> ----- Original Message -----
> From: "James Turner" <tu...@blackbear.com>
> To: "'Struts Developers List'" <st...@jakarta.apache.org>
> Sent: Tuesday, May 13, 2003 1:50 PM
> Subject: RE: 1.1 RC2 status (was RE: [VOTE] Product Change:
> Replace DBPC/Pool with original GDS)
>
>
> >From Bug#: 19525
>
> Many of the taglib tests use String.replaceAll(), which is
> new in 1.4. This makes it impossible to compile and run the
> tests under JDK 1.3.
>
> Proposed solution:
>
> Replace calls to String.replaceAll() with
> commons.lang.StringUtils.replace().
>
> I have done this locally and all tests compile and run
> successfuly after the change.
>
> Impacted tests are: TestCookieTag, TestHeaderTag,
> TestIncludeTag, TestMessageTag, TestMessageTag1-4,
> TestMessageTag1-4_fr, TestPageTag, TestParameterTag,
> TestSizeTag, TestStrutsTag,
> TestWriteTag,TestResourceTag,TestPageTag,TestBaseTag,TestIterateTag
>
> The reporter includes a patch.
>
> > -----Original Message-----
> > From: James Mitchell [mailto:jmitchell@apache.org]
> > Sent: Tuesday, May 13, 2003 1:40 PM
> > To: Struts Developers List
> > Subject: Re: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace
> > DBPC/Pool with original GDS)
> >
> >
> > I must have missed that, what's the issue with taglib tests?
> >
> >
> > --
> > James Mitchell
> > Software Developer/Struts Evangelist http://www.open-tools.org
> >
> >
> >
> > ----- Original Message -----
> > From: "James Turner" <tu...@blackbear.com>
> > To: "'Struts Developers List'" <st...@jakarta.apache.org>
> > Sent: Tuesday, May 13, 2003 12:13 PM
> > Subject: 1.1 RC2 status (was RE: [VOTE] Product Change:
> > Replace DBPC/Pool with original GDS)
> >
> >
> > Well, one of them is a web site bug, one of them seems to be
> > a non-bug pending a reply from the user, I just commited a
> > patch for one of them and the other one is (IMO) a WONT-FIX,
> > so we're left with a compilation issue with the taglib tests
> > in JDK 1.4.
> >
> > James
> >
> > > -----Original Message-----
> > > From: David Graham [mailto:dgraham1980@hotmail.com]
> > > Sent: Tuesday, May 13, 2003 11:39 AM
> > > To: struts-dev@jakarta.apache.org
> > > Subject: RE: [VOTE] Product Change: Replace DBPC/Pool
> with original
> > > GDS, distributed in separate JAR
> > >
> > >
> > > I think FileUpload is the last dependency (there are 2 open bugs
> > > against it). We also need to handle the 4 remaining Struts bugs.
> > >
> > > David
> > >
> > >
> > > >From: "James Turner" <tu...@blackbear.com>
> > > >Reply-To: "Struts Developers List"
> <st...@jakarta.apache.org>
> > > >To: "'Struts Developers List'" <st...@jakarta.apache.org>
> > > >Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with
> > original
> > > >GDS, distributed in separate JAR
> > > >Date: Tue, 13 May 2003 11:30:48 -0400
> > > >
> > > >So the vote was pretty unanimous in doing this, has it been
> > > done, and
> > > >if so, is it true that we're just waiting for FileUpload to
> > > go gold to
> > > >do RC2?
> > > >
> > > >James
> > > >
> > > > > -----Original Message-----
> > > > > From: dmkarr@wondark.www.rattieworldocomfort.com
> > > > > [mailto:dmkarr@wondark.www.rattieworldocomfort.com] On
> > Behalf Of
> > > > > David M. Karr
> > > > > Sent: Sunday, May 11, 2003 2:47 AM
> > > > > To: struts-dev@jakarta.apache.org
> > > > > Subject: Re: [VOTE] Product Change: Replace DBPC/Pool
> > > with original
> > > > > GDS, distributed in separate JAR
> > > > >
> > > > >
> > > > > >>>>> "Ted" == Ted Husted <hu...@apache.org> writes:
> > > > >
> > > > > Ted> The source for the GDS has already been
> uploaded as an
> > > > > independent
> > > > > Ted> package under contrib (struts-legacy). I would
> > > like to change
> > > > > Ted> util.GenericDataSource to wrap this class
> > instead of the
> > > > > DBCP, and
> > > > > Ted> eliminate our dependencies on DBCP and Commons-Pool.
> > > > >
> > > > > Ted> Votes or discussion, please?
> > > > >
> > > > > I'll +1 this also, although I think the name
> > (struts-legacy) is a
> > > > > little odd. Call it what it is. However, it's not
> > worth arguing
> > > > > about.
> > > > >
> > > > > --
> > > > >
> > >
> ===================================================================
> > > > > David M. Karr ; Java/J2EE/XML/Unix/C++
> > > > > dmkarr@earthlink.net ; SCJP; SCWCD
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > >
> --------------------------------------------------------------------
> > > > > -
> > > > > To unsubscribe, e-mail:
> > struts-dev-unsubscribe@jakarta.apache.org
> > > > > For additional commands, e-mail:
> > > struts-dev-help@jakarta.apache.org
> > > > >
> > > >
> > > >
> > > >
> > >
> >
> >---------------------------------------------------------------------
> > > >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > > >For additional commands, e-mail:
> struts-dev-help@jakarta.apache.org
> > > >
> > >
> > > _________________________________________________________________
> > > The new MSN 8: smart spam protection and 2 months FREE*
> > > http://join.msn.com/?page=features/junkmail
> > >
> > >
> > >
> >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail:
> struts-dev-help@jakarta.apache.org
> > >
> >
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace DBPC/Pool with original GDS)
Posted by James Turner <tu...@blackbear.com>.
Commited, which brings us down to one bug that may not be a bug, and a
web site fix. So it's all about FileUpload now...
James
> -----Original Message-----
> From: James Mitchell [mailto:jmitchell@apache.org]
> Sent: Tuesday, May 13, 2003 1:54 PM
> To: Struts Developers List
> Subject: Re: 1.1 RC2 status (was RE: [VOTE] Product Change:
> Replace DBPC/Pool with original GDS)
>
>
> I believe I wrote most of those and did not realize it was a
> 1.4 only call.....sorry.
>
> I'm planning to rewrite most of those tests anyway, so could
> someone just go ahead and commit it (I can't do it myself
> until I get my dsl back up).
>
> Thanks in advance.
>
> --
> James Mitchell
> Software Developer/Struts Evangelist
> http://www.open-tools.org
>
>
>
> ----- Original Message -----
> From: "James Turner" <tu...@blackbear.com>
> To: "'Struts Developers List'" <st...@jakarta.apache.org>
> Sent: Tuesday, May 13, 2003 1:50 PM
> Subject: RE: 1.1 RC2 status (was RE: [VOTE] Product Change:
> Replace DBPC/Pool with original GDS)
>
>
> >From Bug#: 19525
>
> Many of the taglib tests use String.replaceAll(), which is
> new in 1.4. This makes it impossible to compile and run the
> tests under JDK 1.3.
>
> Proposed solution:
>
> Replace calls to String.replaceAll() with
> commons.lang.StringUtils.replace().
>
> I have done this locally and all tests compile and run
> successfuly after the change.
>
> Impacted tests are: TestCookieTag, TestHeaderTag,
> TestIncludeTag, TestMessageTag, TestMessageTag1-4,
> TestMessageTag1-4_fr, TestPageTag, TestParameterTag,
> TestSizeTag, TestStrutsTag,
> TestWriteTag,TestResourceTag,TestPageTag,TestBaseTag,TestIterateTag
>
> The reporter includes a patch.
>
> > -----Original Message-----
> > From: James Mitchell [mailto:jmitchell@apache.org]
> > Sent: Tuesday, May 13, 2003 1:40 PM
> > To: Struts Developers List
> > Subject: Re: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace
> > DBPC/Pool with original GDS)
> >
> >
> > I must have missed that, what's the issue with taglib tests?
> >
> >
> > --
> > James Mitchell
> > Software Developer/Struts Evangelist http://www.open-tools.org
> >
> >
> >
> > ----- Original Message -----
> > From: "James Turner" <tu...@blackbear.com>
> > To: "'Struts Developers List'" <st...@jakarta.apache.org>
> > Sent: Tuesday, May 13, 2003 12:13 PM
> > Subject: 1.1 RC2 status (was RE: [VOTE] Product Change:
> > Replace DBPC/Pool with original GDS)
> >
> >
> > Well, one of them is a web site bug, one of them seems to be
> > a non-bug pending a reply from the user, I just commited a
> > patch for one of them and the other one is (IMO) a WONT-FIX,
> > so we're left with a compilation issue with the taglib tests
> > in JDK 1.4.
> >
> > James
> >
> > > -----Original Message-----
> > > From: David Graham [mailto:dgraham1980@hotmail.com]
> > > Sent: Tuesday, May 13, 2003 11:39 AM
> > > To: struts-dev@jakarta.apache.org
> > > Subject: RE: [VOTE] Product Change: Replace DBPC/Pool
> with original
> > > GDS, distributed in separate JAR
> > >
> > >
> > > I think FileUpload is the last dependency (there are 2 open bugs
> > > against it). We also need to handle the 4 remaining Struts bugs.
> > >
> > > David
> > >
> > >
> > > >From: "James Turner" <tu...@blackbear.com>
> > > >Reply-To: "Struts Developers List"
> <st...@jakarta.apache.org>
> > > >To: "'Struts Developers List'" <st...@jakarta.apache.org>
> > > >Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with
> > original
> > > >GDS, distributed in separate JAR
> > > >Date: Tue, 13 May 2003 11:30:48 -0400
> > > >
> > > >So the vote was pretty unanimous in doing this, has it been
> > > done, and
> > > >if so, is it true that we're just waiting for FileUpload to
> > > go gold to
> > > >do RC2?
> > > >
> > > >James
> > > >
> > > > > -----Original Message-----
> > > > > From: dmkarr@wondark.www.rattieworldocomfort.com
> > > > > [mailto:dmkarr@wondark.www.rattieworldocomfort.com] On
> > Behalf Of
> > > > > David M. Karr
> > > > > Sent: Sunday, May 11, 2003 2:47 AM
> > > > > To: struts-dev@jakarta.apache.org
> > > > > Subject: Re: [VOTE] Product Change: Replace DBPC/Pool
> > > with original
> > > > > GDS, distributed in separate JAR
> > > > >
> > > > >
> > > > > >>>>> "Ted" == Ted Husted <hu...@apache.org> writes:
> > > > >
> > > > > Ted> The source for the GDS has already been
> uploaded as an
> > > > > independent
> > > > > Ted> package under contrib (struts-legacy). I would
> > > like to change
> > > > > Ted> util.GenericDataSource to wrap this class
> > instead of the
> > > > > DBCP, and
> > > > > Ted> eliminate our dependencies on DBCP and Commons-Pool.
> > > > >
> > > > > Ted> Votes or discussion, please?
> > > > >
> > > > > I'll +1 this also, although I think the name
> > (struts-legacy) is a
> > > > > little odd. Call it what it is. However, it's not
> > worth arguing
> > > > > about.
> > > > >
> > > > > --
> > > > >
> > >
> ===================================================================
> > > > > David M. Karr ; Java/J2EE/XML/Unix/C++
> > > > > dmkarr@earthlink.net ; SCJP; SCWCD
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > >
> --------------------------------------------------------------------
> > > > > -
> > > > > To unsubscribe, e-mail:
> > struts-dev-unsubscribe@jakarta.apache.org
> > > > > For additional commands, e-mail:
> > > struts-dev-help@jakarta.apache.org
> > > > >
> > > >
> > > >
> > > >
> > >
> >
> >---------------------------------------------------------------------
> > > >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > > >For additional commands, e-mail:
> struts-dev-help@jakarta.apache.org
> > > >
> > >
> > > _________________________________________________________________
> > > The new MSN 8: smart spam protection and 2 months FREE*
> > > http://join.msn.com/?page=features/junkmail
> > >
> > >
> > >
> >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail:
> struts-dev-help@jakarta.apache.org
> > >
> >
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace DBPC/Pool with original GDS)
Posted by James Mitchell <jm...@apache.org>.
I believe I wrote most of those and did not realize it was a 1.4 only
call.....sorry.
I'm planning to rewrite most of those tests anyway, so could someone just go
ahead and commit it (I can't do it myself until I get my dsl back up).
Thanks in advance.
--
James Mitchell
Software Developer/Struts Evangelist
http://www.open-tools.org
----- Original Message -----
From: "James Turner" <tu...@blackbear.com>
To: "'Struts Developers List'" <st...@jakarta.apache.org>
Sent: Tuesday, May 13, 2003 1:50 PM
Subject: RE: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace
DBPC/Pool with original GDS)
>From Bug#: 19525
Many of the taglib tests use String.replaceAll(), which is new in 1.4.
This
makes it impossible to compile and run the tests under JDK 1.3.
Proposed solution:
Replace calls to String.replaceAll() with
commons.lang.StringUtils.replace().
I have done this locally and all tests compile and run successfuly after
the change.
Impacted tests are: TestCookieTag, TestHeaderTag, TestIncludeTag,
TestMessageTag, TestMessageTag1-4, TestMessageTag1-4_fr, TestPageTag,
TestParameterTag, TestSizeTag, TestStrutsTag,
TestWriteTag,TestResourceTag,TestPageTag,TestBaseTag,TestIterateTag
The reporter includes a patch.
> -----Original Message-----
> From: James Mitchell [mailto:jmitchell@apache.org]
> Sent: Tuesday, May 13, 2003 1:40 PM
> To: Struts Developers List
> Subject: Re: 1.1 RC2 status (was RE: [VOTE] Product Change:
> Replace DBPC/Pool with original GDS)
>
>
> I must have missed that, what's the issue with taglib tests?
>
>
> --
> James Mitchell
> Software Developer/Struts Evangelist
> http://www.open-tools.org
>
>
>
> ----- Original Message -----
> From: "James Turner" <tu...@blackbear.com>
> To: "'Struts Developers List'" <st...@jakarta.apache.org>
> Sent: Tuesday, May 13, 2003 12:13 PM
> Subject: 1.1 RC2 status (was RE: [VOTE] Product Change:
> Replace DBPC/Pool with original GDS)
>
>
> Well, one of them is a web site bug, one of them seems to be
> a non-bug pending a reply from the user, I just commited a
> patch for one of them and the other one is (IMO) a WONT-FIX,
> so we're left with a compilation issue with the taglib tests
> in JDK 1.4.
>
> James
>
> > -----Original Message-----
> > From: David Graham [mailto:dgraham1980@hotmail.com]
> > Sent: Tuesday, May 13, 2003 11:39 AM
> > To: struts-dev@jakarta.apache.org
> > Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with original
> > GDS, distributed in separate JAR
> >
> >
> > I think FileUpload is the last dependency (there are 2 open bugs
> > against it). We also need to handle the 4 remaining Struts bugs.
> >
> > David
> >
> >
> > >From: "James Turner" <tu...@blackbear.com>
> > >Reply-To: "Struts Developers List" <st...@jakarta.apache.org>
> > >To: "'Struts Developers List'" <st...@jakarta.apache.org>
> > >Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with
> original
> > >GDS, distributed in separate JAR
> > >Date: Tue, 13 May 2003 11:30:48 -0400
> > >
> > >So the vote was pretty unanimous in doing this, has it been
> > done, and
> > >if so, is it true that we're just waiting for FileUpload to
> > go gold to
> > >do RC2?
> > >
> > >James
> > >
> > > > -----Original Message-----
> > > > From: dmkarr@wondark.www.rattieworldocomfort.com
> > > > [mailto:dmkarr@wondark.www.rattieworldocomfort.com] On
> Behalf Of
> > > > David M. Karr
> > > > Sent: Sunday, May 11, 2003 2:47 AM
> > > > To: struts-dev@jakarta.apache.org
> > > > Subject: Re: [VOTE] Product Change: Replace DBPC/Pool
> > with original
> > > > GDS, distributed in separate JAR
> > > >
> > > >
> > > > >>>>> "Ted" == Ted Husted <hu...@apache.org> writes:
> > > >
> > > > Ted> The source for the GDS has already been uploaded as an
> > > > independent
> > > > Ted> package under contrib (struts-legacy). I would
> > like to change
> > > > Ted> util.GenericDataSource to wrap this class
> instead of the
> > > > DBCP, and
> > > > Ted> eliminate our dependencies on DBCP and Commons-Pool.
> > > >
> > > > Ted> Votes or discussion, please?
> > > >
> > > > I'll +1 this also, although I think the name
> (struts-legacy) is a
> > > > little odd. Call it what it is. However, it's not
> worth arguing
> > > > about.
> > > >
> > > > --
> > > >
> > ===================================================================
> > > > David M. Karr ; Java/J2EE/XML/Unix/C++
> > > > dmkarr@earthlink.net ; SCJP; SCWCD
> > > >
> > > >
> > > >
> > > >
> > > >
> > --------------------------------------------------------------------
> > > > -
> > > > To unsubscribe, e-mail:
> struts-dev-unsubscribe@jakarta.apache.org
> > > > For additional commands, e-mail:
> > struts-dev-help@jakarta.apache.org
> > > >
> > >
> > >
> > >
> >
> >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> > >
> >
> > _________________________________________________________________
> > The new MSN 8: smart spam protection and 2 months FREE*
> > http://join.msn.com/?page=features/junkmail
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace DBPC/Pool with original GDS)
Posted by James Turner <tu...@blackbear.com>.
>From Bug#: 19525
Many of the taglib tests use String.replaceAll(), which is new in 1.4.
This
makes it impossible to compile and run the tests under JDK 1.3.
Proposed solution:
Replace calls to String.replaceAll() with
commons.lang.StringUtils.replace().
I have done this locally and all tests compile and run successfuly after
the change.
Impacted tests are: TestCookieTag, TestHeaderTag, TestIncludeTag,
TestMessageTag, TestMessageTag1-4, TestMessageTag1-4_fr, TestPageTag,
TestParameterTag, TestSizeTag, TestStrutsTag,
TestWriteTag,TestResourceTag,TestPageTag,TestBaseTag,TestIterateTag
The reporter includes a patch.
> -----Original Message-----
> From: James Mitchell [mailto:jmitchell@apache.org]
> Sent: Tuesday, May 13, 2003 1:40 PM
> To: Struts Developers List
> Subject: Re: 1.1 RC2 status (was RE: [VOTE] Product Change:
> Replace DBPC/Pool with original GDS)
>
>
> I must have missed that, what's the issue with taglib tests?
>
>
> --
> James Mitchell
> Software Developer/Struts Evangelist
> http://www.open-tools.org
>
>
>
> ----- Original Message -----
> From: "James Turner" <tu...@blackbear.com>
> To: "'Struts Developers List'" <st...@jakarta.apache.org>
> Sent: Tuesday, May 13, 2003 12:13 PM
> Subject: 1.1 RC2 status (was RE: [VOTE] Product Change:
> Replace DBPC/Pool with original GDS)
>
>
> Well, one of them is a web site bug, one of them seems to be
> a non-bug pending a reply from the user, I just commited a
> patch for one of them and the other one is (IMO) a WONT-FIX,
> so we're left with a compilation issue with the taglib tests
> in JDK 1.4.
>
> James
>
> > -----Original Message-----
> > From: David Graham [mailto:dgraham1980@hotmail.com]
> > Sent: Tuesday, May 13, 2003 11:39 AM
> > To: struts-dev@jakarta.apache.org
> > Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with original
> > GDS, distributed in separate JAR
> >
> >
> > I think FileUpload is the last dependency (there are 2 open bugs
> > against it). We also need to handle the 4 remaining Struts bugs.
> >
> > David
> >
> >
> > >From: "James Turner" <tu...@blackbear.com>
> > >Reply-To: "Struts Developers List" <st...@jakarta.apache.org>
> > >To: "'Struts Developers List'" <st...@jakarta.apache.org>
> > >Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with
> original
> > >GDS, distributed in separate JAR
> > >Date: Tue, 13 May 2003 11:30:48 -0400
> > >
> > >So the vote was pretty unanimous in doing this, has it been
> > done, and
> > >if so, is it true that we're just waiting for FileUpload to
> > go gold to
> > >do RC2?
> > >
> > >James
> > >
> > > > -----Original Message-----
> > > > From: dmkarr@wondark.www.rattieworldocomfort.com
> > > > [mailto:dmkarr@wondark.www.rattieworldocomfort.com] On
> Behalf Of
> > > > David M. Karr
> > > > Sent: Sunday, May 11, 2003 2:47 AM
> > > > To: struts-dev@jakarta.apache.org
> > > > Subject: Re: [VOTE] Product Change: Replace DBPC/Pool
> > with original
> > > > GDS, distributed in separate JAR
> > > >
> > > >
> > > > >>>>> "Ted" == Ted Husted <hu...@apache.org> writes:
> > > >
> > > > Ted> The source for the GDS has already been uploaded as an
> > > > independent
> > > > Ted> package under contrib (struts-legacy). I would
> > like to change
> > > > Ted> util.GenericDataSource to wrap this class
> instead of the
> > > > DBCP, and
> > > > Ted> eliminate our dependencies on DBCP and Commons-Pool.
> > > >
> > > > Ted> Votes or discussion, please?
> > > >
> > > > I'll +1 this also, although I think the name
> (struts-legacy) is a
> > > > little odd. Call it what it is. However, it's not
> worth arguing
> > > > about.
> > > >
> > > > --
> > > >
> > ===================================================================
> > > > David M. Karr ; Java/J2EE/XML/Unix/C++
> > > > dmkarr@earthlink.net ; SCJP; SCWCD
> > > >
> > > >
> > > >
> > > >
> > > >
> > --------------------------------------------------------------------
> > > > -
> > > > To unsubscribe, e-mail:
> struts-dev-unsubscribe@jakarta.apache.org
> > > > For additional commands, e-mail:
> > struts-dev-help@jakarta.apache.org
> > > >
> > >
> > >
> > >
> >
> >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> > >
> >
> > _________________________________________________________________
> > The new MSN 8: smart spam protection and 2 months FREE*
> > http://join.msn.com/?page=features/junkmail
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace DBPC/Pool with original GDS)
Posted by James Mitchell <jm...@apache.org>.
I must have missed that, what's the issue with taglib tests?
--
James Mitchell
Software Developer/Struts Evangelist
http://www.open-tools.org
----- Original Message -----
From: "James Turner" <tu...@blackbear.com>
To: "'Struts Developers List'" <st...@jakarta.apache.org>
Sent: Tuesday, May 13, 2003 12:13 PM
Subject: 1.1 RC2 status (was RE: [VOTE] Product Change: Replace DBPC/Pool
with original GDS)
Well, one of them is a web site bug, one of them seems to be a non-bug
pending a reply from the user, I just commited a patch for one of them
and the other one is (IMO) a WONT-FIX, so we're left with a compilation
issue with the taglib tests in JDK 1.4.
James
> -----Original Message-----
> From: David Graham [mailto:dgraham1980@hotmail.com]
> Sent: Tuesday, May 13, 2003 11:39 AM
> To: struts-dev@jakarta.apache.org
> Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with
> original GDS, distributed in separate JAR
>
>
> I think FileUpload is the last dependency (there are 2 open
> bugs against
> it). We also need to handle the 4 remaining Struts bugs.
>
> David
>
>
> >From: "James Turner" <tu...@blackbear.com>
> >Reply-To: "Struts Developers List" <st...@jakarta.apache.org>
> >To: "'Struts Developers List'" <st...@jakarta.apache.org>
> >Subject: RE: [VOTE] Product Change: Replace DBPC/Pool with original
> >GDS,
> >distributed in separate JAR
> >Date: Tue, 13 May 2003 11:30:48 -0400
> >
> >So the vote was pretty unanimous in doing this, has it been
> done, and
> >if so, is it true that we're just waiting for FileUpload to
> go gold to
> >do RC2?
> >
> >James
> >
> > > -----Original Message-----
> > > From: dmkarr@wondark.www.rattieworldocomfort.com
> > > [mailto:dmkarr@wondark.www.rattieworldocomfort.com] On Behalf Of
> > > David M. Karr
> > > Sent: Sunday, May 11, 2003 2:47 AM
> > > To: struts-dev@jakarta.apache.org
> > > Subject: Re: [VOTE] Product Change: Replace DBPC/Pool
> with original
> > > GDS, distributed in separate JAR
> > >
> > >
> > > >>>>> "Ted" == Ted Husted <hu...@apache.org> writes:
> > >
> > > Ted> The source for the GDS has already been uploaded as an
> > > independent
> > > Ted> package under contrib (struts-legacy). I would
> like to change
> > > Ted> util.GenericDataSource to wrap this class instead of the
> > > DBCP, and
> > > Ted> eliminate our dependencies on DBCP and Commons-Pool.
> > >
> > > Ted> Votes or discussion, please?
> > >
> > > I'll +1 this also, although I think the name (struts-legacy) is a
> > > little odd. Call it what it is. However, it's not worth arguing
> > > about.
> > >
> > > --
> > >
> ===================================================================
> > > David M. Karr ; Java/J2EE/XML/Unix/C++
> > > dmkarr@earthlink.net ; SCJP; SCWCD
> > >
> > >
> > >
> > >
> > >
> --------------------------------------------------------------------
> > > -
> > > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail:
> struts-dev-help@jakarta.apache.org
> > >
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
>
> _________________________________________________________________
> The new MSN 8: smart spam protection and 2 months FREE*
> http://join.msn.com/?page=features/junkmail
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org