You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:19:45 UTC
[GitHub] [airflow] turbaszek opened a new pull request #12067: Add template fields renderers to Biguery and Dataproc operators
turbaszek opened a new pull request #12067:
URL: https://github.com/apache/airflow/pull/12067
Related to #11177
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek removed a comment on pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
turbaszek removed a comment on pull request #12067:
URL: https://github.com/apache/airflow/pull/12067#issuecomment-721220404
> For me it looks like a case where the extension pack of a game is released before the game.
@RosterIn this will be part of Airflow 2.0. We do not cherrypick every change to 1.10 line, so this change is not unique :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek edited a comment on pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
turbaszek edited a comment on pull request #12067:
URL: https://github.com/apache/airflow/pull/12067#issuecomment-721222056
> > For me it looks like a case where the extension pack of a game is released before the game.
@RosterIn this will be part of Airflow 2.0. We do not cherrypick every change to 1.10 line, so this change is not unique :) But I understand your disappointment. We need providers to ease migration but we also needs to move on with new features. What would you suggest to do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12067:
URL: https://github.com/apache/airflow/pull/12067#issuecomment-721438415
Tried rebasing but missing permissions:
```
❯ git push github-desktop-turbaszek HEAD:template-renderes-bq-dataproc -f
remote: Permission to PolideaInternal/airflow.git denied to kaxil.
fatal: unable to access 'https://github.com/PolideaInternal/airflow.git/': The requested URL returned error: 403
```
Can you please rebase on latest master please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #12067:
URL: https://github.com/apache/airflow/pull/12067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12067:
URL: https://github.com/apache/airflow/pull/12067#issuecomment-721414079
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12067:
URL: https://github.com/apache/airflow/pull/12067#issuecomment-721220404
> For me it looks like a case where the extension pack of a game is released before the game.
@RosterIn this will be part of Airflow 2.0. We do not cherrypick every change to 1.10 line, so this change is not unique :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12067:
URL: https://github.com/apache/airflow/pull/12067#issuecomment-721222056
> > For me it looks like a case where the extension pack of a game is released before the game.
>
> @RosterIn this will be part of Airflow 2.0. We do not cherrypick every change to 1.10 line, so this change is not unique :) But I understand your disappointment. We need providers to ease migration but we also needs to move on with new features. What would you suggest to do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
RosterIn commented on pull request #12067:
URL: https://github.com/apache/airflow/pull/12067#issuecomment-721184462
Airflow has come to a very weird place where providers shows code lines that can never be used due to key functionality is missing in official airflow releases.
In that example this renders behavior was added to BaseOperator but was never released.
https://github.com/apache/airflow/pull/11061
This resulting in us users saying "wow this is cool! lets try this" only to eventually see that we can't because the core feature wasn't release in any official version.
For me it looks like a case where the extension pack of a game is released before the game.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12067:
URL: https://github.com/apache/airflow/pull/12067#issuecomment-721609044
> Tried rebasing but missing permissions:
>
> ```
> ❯ git push github-desktop-turbaszek HEAD:template-renderes-bq-dataproc -f
> remote: Permission to PolideaInternal/airflow.git denied to kaxil.
> fatal: unable to access 'https://github.com/PolideaInternal/airflow.git/': The requested URL returned error: 403
> ```
>
> Can you please rebase on latest master please
@kaxil check this tool: https://github.com/ldez/prm kudos to @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12067: Add template fields renderers to Biguery and Dataproc operators
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12067:
URL: https://github.com/apache/airflow/pull/12067#issuecomment-721758509
> @kaxil check this tool: https://github.com/ldez/prm kudos to @mik-laj
That looks good, thanks @turbaszek and @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org