[GitHub] [shardingsphere] zhujunxxxxx commented on a change in pull request #10287: Move the user configuration to authority rule

[GitBox <gi...@apache.org>]

zhujunxxxxx commented on a change in pull request #10287:
URL: https://github.com/apache/shardingsphere/pull/10287#discussion_r629153249



##########
File path: shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/metadata/MetaDataContextsBuilder.java
##########
@@ -94,7 +93,7 @@ public StandardMetaDataContexts build() throws SQLException {
         for (String each : schemaRuleConfigs.keySet()) {
             mataDataMap.put(each, buildMetaData(each));
         }
-        return new StandardMetaDataContexts(mataDataMap, buildGlobalSchemaMetaData(mataDataMap), executorEngine, new ShardingSphereUsers(users), props);
+        return new StandardMetaDataContexts(mataDataMap, buildGlobalSchemaMetaData(mataDataMap), executorEngine, new ShardingSphereUsers(getUsersFromAuthorityRule()), props);

Review comment:
       @tristaZero 
   > ShardingSphereUsers(users) is expected to be removed from StandardMetaDataContexts
   it's need remove? Ok, next PR I will remove it.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org