[jira] Commented: (DERBY-3189) Replication: Add connection url command options for starting and stopping master

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542782 ] 

Knut Anders Hatlen commented on DERBY-3189:
-------------------------------------------

1a looks like a fine first increment to me. I will commit the patch when I have run the regression tests, unless there are objections.

If I read the code correctly, getConenction("...startMaster=true") and getConenction("...stopMaster=true") will return a connection object. I have no strong feelings, but I just wondered if it would be more consistent to throw an exception like shutdown=true does, at least for stopMaster. Not that I'm a big fan of messages like "ERROR: Replication successfully started/stopped"... ;)

And a tiny nit:

+                                                org.apache.derby.iapi.
+                                                services.replication.
+                                                master.MasterFactory.

Perhaps an import would be better than breaking the package name over three lines? ;)

> Replication: Add connection url command options for starting and stopping master
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-3189
>                 URL: https://issues.apache.org/jira/browse/DERBY-3189
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: Jørgen Løland
>         Attachments: derby-3189-1a.diff, derby-3189-1a.stat
>
>
> Add commands to start and stop the replication master using properties or connection url. Example:
> 'jdbc:derby:<host><masterdb>;startMaster=true';
> 'jdbc:derby:<host><masterdb>;stopMaster=true';
> Connection url options that must be recognized:
> startMaster=true
> stopMaster=true
> slaveHost=<host> (required)
> slavePort=<port> (optional, defaults to 8001)
> See functional specification on Derby-2872 for further details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.