[GitHub] rob05c commented on a change in pull request #3051: makes link to TP documentation configurable

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #3051: makes link to TP documentation configurable
URL: https://github.com/apache/trafficcontrol/pull/3051#discussion_r235419229
 
 

 ##########
 File path: traffic_ops/app/templates/not_found.html.ep
 ##########
 @@ -27,7 +27,7 @@
 		  </div>
 
 			<div style="margin-top:20px;clear:both;">
-					If you are looking for a web page, the old Traffic Ops user interface was removed in Traffic Ops 4.0. Please use the <a href="https://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_portal/usingtrafficportal.html#usingtrafficportal">Traffic Portal</a> instead.
+					If you are looking for a web page, the old Traffic Ops user interface was removed in Traffic Ops 4.0. Please use the <a href="<%= $config->{'portal'}{'docs_url'} %>"> Traffic Portal</a> instead.
 
 Review comment:
   It seems like every CDN operator is going to immediately set this to the link to their Traffic Portal, I can't imagine why anyone _wouldn't_ link there, and thus have `"docs_url" : "https://trafficops.example.net"` in their config with this name.
   
   Would you object to changing the config from `docs_url` to something like `traffic_portal_deprecation_link_uri`? That way it makes sense as the docs which it defaults to in the repo, but also isn't confusing to operators when it's set to the instance URI?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services