[GitHub] [doris] yangzhg commented on a diff in pull request #10409: [fix] (mem tracker) Fix inaccurate mem tracker leads to load OOM

[GitBox <gi...@apache.org>]

yangzhg commented on code in PR #10409:
URL: https://github.com/apache/doris/pull/10409#discussion_r906928019


##########
be/src/runtime/load_channel.h:
##########
@@ -39,9 +39,8 @@ class Cache;
 // corresponding to a certain load job
 class LoadChannel {
 public:
-    LoadChannel(const UniqueId& load_id, int64_t load_mem_limit, int64_t channel_mem_limit,
-                int64_t timeout_s, bool is_high_priority, const std::string& sender_ip,
-                bool is_vec);
+    LoadChannel(const UniqueId& load_id, std::shared_ptr<MemTracker>& mem_tracker,
+                int64_t timeout_s, bool is_high_priority, const std::string& sender_ip, bool is_ve);

Review Comment:
   why rename to is_ve



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org