You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/21 15:34:00 UTC
[jira] [Work logged] (BEAM-14136) [Go SDK] Clean up staticcheck and linter warnings
[ https://issues.apache.org/jira/browse/BEAM-14136?focusedWorklogId=745183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745183 ]
ASF GitHub Bot logged work on BEAM-14136:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 15:33
Start Date: 21/Mar/22 15:33
Worklog Time Spent: 10m
Work Description: jrmccluskey opened a new pull request #17137:
URL: https://github.com/apache/beam/pull/17137
Addresses a number of staticcheck and linter warnings, mostly use of nil contexts in unit tests and missing comments for exported functions and variables.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 745183)
Remaining Estimate: 0h
Time Spent: 10m
> [Go SDK] Clean up staticcheck and linter warnings
> -------------------------------------------------
>
> Key: BEAM-14136
> URL: https://issues.apache.org/jira/browse/BEAM-14136
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Address staticcheck warnings regarding the use of nil contexts in gcpopt's options_test.go file and the provision_test.go file. Replace nil contexts with context.Background().
> There are also a number of variables with improper names, as well as exported functions/variables that need documentation comments.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)