[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1437: DISPATCH-2266: Increase container timeout to 3 seconds on AsyncTestRe…

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #1437:
URL: https://github.com/apache/qpid-dispatch/pull/1437#discussion_r749506131



##########
File path: tests/system_test.py
##########
@@ -926,15 +926,15 @@ def get_queue_stats(self):
         return self.queue_stats % (self.num_queue_puts, self.num_queue_gets)
 
     def _main(self):
-        self._container.timeout = 0.5
+        self._container.timeout = 3.0

Review comment:
       Maybe use a global constant for the three seconds? So that the timeouts can be unified across tests, based on what they "mean". Something like `DEFAULT_TEST_CLIENT_CONTAINER_TIMEOUT = 3`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org