You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2010/08/06 09:56:15 UTC
[jira] Created: (CASSANDRA-1367) Upgrade to Thrift 0.3.0
Upgrade to Thrift 0.3.0
-----------------------
Key: CASSANDRA-1367
URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Johan Oskarsson
Priority: Minor
Fix For: 0.7 beta 1
There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
http://www.apache.org/dyn/closer.cgi?path=/incubator/thrift/0.3.0-incubating/thrift-0.3.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.3.0
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896049#action_12896049 ]
Johan Oskarsson commented on CASSANDRA-1367:
--------------------------------------------
If it's a serious issue I assume they'll release a 0.3.1 to fix it, otherwise we'll catch it in the next release.
> Upgrade to Thrift 0.3.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.7 beta 1
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dyn/closer.cgi?path=/incubator/thrift/0.3.0-incubating/thrift-0.3.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: (was: 1367_v4.patch)
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923535#action_12923535 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
can we fix by overriding Inner serialization instead, with writeObject etc?
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.3.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903176#action_12903176 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
Thrift 0.4 is out now which includes the performance improvements, so we could definitely use that.
> Upgrade to Thrift 0.3.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.7 beta 2
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dyn/closer.cgi?path=/incubator/thrift/0.3.0-incubating/thrift-0.3.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923532#action_12923532 ]
T Jake Luciani commented on CASSANDRA-1367:
-------------------------------------------
Ah sorry, it's the Inner class. This has a Token member
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923507#action_12923507 ]
T Jake Luciani commented on CASSANDRA-1367:
-------------------------------------------
Ok, I can fix these.
ByteArrayToken is needed for MerkleTree serialization. ByteBuffer isn't Serializable so I convert ByteToken to ByteArrayToken.
We have to use position() as arrayOffset() is almost always zero. I'm following the logic here http://blog.rapleaf.com/dev/2010/10/19/striving-for-zero-copies-with-thrift-0.5/
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923513#action_12923513 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
if thrift is creating multiple bytebuffers from the same byte[] with the same offset it is broken. look at HeapByteBuffer.slice, the idea is the offset should be the start of the valid bytes in the buffer. position is mutable by the relative get methods but offset is not. or hell, look at BB equals/hashcode.
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: (was: 1367_v3.patch)
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v4.patch
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923824#action_12923824 ]
Hudson commented on CASSANDRA-1367:
-----------------------------------
Integrated in Cassandra #573 (See [https://hudson.apache.org/hudson/job/Cassandra/573/])
upgrade to Thrift 0.5
patch by Jake Luciani; reviewed by jbellis for CASSANDRA-1367
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: 1367_v5.patch, 1367_v6.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923524#action_12923524 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
bq. RowHash class
is that the JDK being retarded? because there are no instances of RowHash to serialize either.
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923504#action_12923504 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
MurmurHash is broken, it should be using data.get(index) (it also shouldn't take a separate length value since BB knows its length).
the use of position() scares me, it's a bug waiting to happen, e.g. in FBUtilities.hash
block.position()+block.arrayOffset()
all of these these should all just be block.arrayOffset().
Similarly remaining() scares me. We don't "use up" our ByteBuffers on purpose except in very unusual cases (e.g. your BBUtil.getLong), all? of these should be limit - offset instead.
I _suspect_ that there is a bug from position/remaining causing the test failure: it's building the index on the test rows and being rejected at the row-level bloom filter saying "this row doesn't exist" which is completely bogus.
style: space after commas and between operators please.
Let's fix the above and see where that gets us.
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923690#action_12923690 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
I get a ton of compile errors from v6. here is the first:
{code}
[javac] /Users/jonathan/projects/cassandra/git-trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/AuthenticationException.java:54: org.apache.cassandra.thrift.AuthenticationException is not abstract and does not override abstract method setFieldValue(int,java.lang.Object) in org.apache.thrift.TBase
[javac] public class AuthenticationException extends Exception implements TBase<AuthenticationException, AuthenticationException._Fields>, java.io.Serializable, Cloneable {
[javac] ^
[javac] /Users/jonathan/projects/cassandra/git-trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/AuthenticationException.java:153: method does not override or implement a method from a supertype
[javac] @Override
[javac] ^
{code}
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, 1367_v6.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.4.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1367:
--------------------------------------
Fix Version/s: 0.7.0
(was: 0.7 beta 2)
> Upgrade to Thrift 0.4.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.7.0
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: 1367_v5.patch
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v4.patch, 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923515#action_12923515 ]
T Jake Luciani commented on CASSANDRA-1367:
-------------------------------------------
RowHash class
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.4.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1367:
--------------------------------------
Fix Version/s: 0.8
(was: 0.7.0)
> Upgrade to Thrift 0.4.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923546#action_12923546 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
bq. as Stu mentioned, BBUtil equals and hashcode are unnecessary
we can also get rid of getLong by using bb absolute methods instead
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-1367.
---------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.8)
0.7.0
Reviewer: jbellis
Assignee: T Jake Luciani
committed. An impressive effort!
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: 1367_v5.patch, 1367_v6.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923514#action_12923514 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
bq. ByteArrayToken is needed for MerkleTree serialization. ByteBuffer isn't Serializable so I convert ByteToken to ByteArrayToken
MerkleTree doesn't have any member Token fields that I can see...?
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923517#action_12923517 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
bq. i think limit - offset is what capacity() gives you.
turns out this is wrong.
what we really want is capacity - offset. limit is some weird-ass inverse mark. Buffer doc explains,
bq. 0 <= mark <= position <= limit <= capacity ... A read-only buffer does not allow its content to be changed, but its mark, position, and limit values are mutable.
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923508#action_12923508 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
i _think_ limit - offset is what capacity() gives you.
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923437#action_12923437 ]
Jeremy Hanna commented on CASSANDRA-1367:
-----------------------------------------
Just as an fyi, nirmal just got THRIFT-106 committed for version 0.6 which enables Java client SSL. Just for those interested. There will always be feature X enabled in revision Y. I guess if thrift is coming out with regular versions now, we can just upgrade when version Z comes out (instead of doing builds of revision Y).
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367.patch, 1367_v2.patch
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923522#action_12923522 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
... ByteBuffer.wrap cleared things up for me: you're right, we do need to be using position / limit / remaining. what a brain-damaged api. It may be a mistake for Thrift to be using ByteBuffer instead of rolling its own but obviously we're stuck with it here.
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: 1367_v3.patch
Added missing files
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367.patch, 1367_v2.patch, 1367_v3.patch
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.3.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896087#action_12896087 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
It's not a fix, it's a huge performance increase.
IMO having THRIFT-830 and THRIFT-831 would be much more useful than being on 0.3 exactly (which affects clients not at all).
> Upgrade to Thrift 0.3.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.7 beta 1
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dyn/closer.cgi?path=/incubator/thrift/0.3.0-incubating/thrift-0.3.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: 1367_v6.patch
This patch removes many ButeBufferUtil calls, removes ByteArrayToken, and fixes murmur hash
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, 1367_v6.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: (was: 1367.patch)
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v4.patch
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923611#action_12923611 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
(re MurmurHash, the "right" api is to take byte[] offset length, so it can be used for both ByteBuffer callers and byte[] ones)
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923485#action_12923485 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
patch has class named CopyOfByteArrayToken
as Stu mentioned, BBUtil equals and hashcode are unnecessary
ByteArrayToken is broken (discards offset and limit information) and should be unnecessary in the first place, if something in BytesToken is causing problems then we should fix that instead (but this is not the cause of the test failure)
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v4.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: (was: 1367_v2.patch)
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v4.patch
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: 1367.patch
This is my first pass at this issue.
The patch does not include the thrift 0.5 jar, so you need to remove the current jar and replace with 0.5 jar
All tests pass except for TestMutations.test_dynamic_indexes_with_system_update_cf
I'd appreciate if someone with fresh eyes could look at this.
-Jake
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367.patch
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1367:
--------------------------------------
Summary: Upgrade to Thrift 0.5.0 (was: Upgrade to Thrift 0.4.0)
... thrift 0.5 now.
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.3.0
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896037#action_12896037 ]
Jeremy Hanna commented on CASSANDRA-1367:
-----------------------------------------
would we be able to keep using a stable release or would things like THRIFT-831 make us decide to go back to revision specific versions?
maybe it depends on whether thrift releases are frequent enough.
> Upgrade to Thrift 0.3.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.7 beta 1
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dyn/closer.cgi?path=/incubator/thrift/0.3.0-incubating/thrift-0.3.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: libthrift-0.5.jar
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v4.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.4.0
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated CASSANDRA-1367:
---------------------------------------
Summary: Upgrade to Thrift 0.4.0 (was: Upgrade to Thrift 0.3.0)
Description:
There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
was:
There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
http://www.apache.org/dyn/closer.cgi?path=/incubator/thrift/0.3.0-incubating/thrift-0.3.0.tar.gz
> Upgrade to Thrift 0.4.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.7 beta 2
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923547#action_12923547 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
re above, IMO we should treat position/limit as immutable, we could even check if assertions are enabled and wrap BB in methods that throw errors on non-absolute methods, although that might be more paranoid than necessary
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923548#action_12923548 ]
Jonathan Ellis commented on CASSANDRA-1367:
-------------------------------------------
bq. can we fix by overriding Inner serialization instead, with writeObject etc?
I suppose we could make Token serializable instead the same way, too.
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: 1367_v4.patch
Fixed so patch will apply cleanly
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v4.patch
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1367:
--------------------------------------
Attachment: 1367_v2.patch
Removed the configuration changes that should not have been in first patch.
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367.patch, 1367_v2.patch
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1367) Upgrade to Thrift 0.5.0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1367:
--------------------------------------
Comment: was deleted
(was: I get a ton of compile errors from v6. here is the first:
{code}
[javac] /Users/jonathan/projects/cassandra/git-trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/AuthenticationException.java:54: org.apache.cassandra.thrift.AuthenticationException is not abstract and does not override abstract method setFieldValue(int,java.lang.Object) in org.apache.thrift.TBase
[javac] public class AuthenticationException extends Exception implements TBase<AuthenticationException, AuthenticationException._Fields>, java.io.Serializable, Cloneable {
[javac] ^
[javac] /Users/jonathan/projects/cassandra/git-trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/AuthenticationException.java:153: method does not override or implement a method from a supertype
[javac] @Override
[javac] ^
{code})
> Upgrade to Thrift 0.5.0
> -----------------------
>
> Key: CASSANDRA-1367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1367
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 1367_v5.patch, 1367_v6.patch, libthrift-0.5.jar
>
>
> There's finally a new thrift release out. This gives us a chance to standardize on a release instead of just a revision of thrift trunk.
> http://www.apache.org/dist/incubator/thrift/0.4.0-incubating/thrift-0.4.0.tar.gz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.