You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/02/03 19:19:15 UTC
Review Request 30569: Add a 'Prepare Backups' Stage to Rolling Upgrade
before ZooKeeper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-9456
https://issues.apache.org/jira/browse/AMBARI-9456
Repository: ambari
Description
-------
There should be an explicit stage at the beginning of Rolling Upgrade called 'Prepare Backups' that does pre-upgrade steps for the following :
- HBase
- HDFS
- Hive
- Oozie
As part of this task, we need to ensure that backups steps are removed from other stages (so that they are not duplicated).
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 0d250d3
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 28d0b1f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d878fee
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml cc8bd0a
Diff: https://reviews.apache.org/r/30569/diff/
Testing
-------
Manual testing.
Unit tests updated.
All tests pass.
Thanks,
Tom Beerbower
Re: Review Request 30569: Add a 'Prepare Backups' Stage to Rolling
Upgrade before ZooKeeper
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On Feb. 3, 2015, 6:26 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml, lines 433-435
> > <https://reviews.apache.org/r/30569/diff/1/?file=845796#file845796line433>
> >
> > This block still needs to be in the HIVE section. It's not backup, and it needs to be done before the restart.
Yikes... good catch. I'm not sure how I dropped it.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/#review70782
-----------------------------------------------------------
On Feb. 3, 2015, 6:19 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30569/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 6:19 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9456
> https://issues.apache.org/jira/browse/AMBARI-9456
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There should be an explicit stage at the beginning of Rolling Upgrade called 'Prepare Backups' that does pre-upgrade steps for the following :
>
> - HBase
> - HDFS
> - Hive
> - Oozie
>
> As part of this task, we need to ensure that backups steps are removed from other stages (so that they are not duplicated).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 0d250d3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 28d0b1f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d878fee
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml cc8bd0a
>
> Diff: https://reviews.apache.org/r/30569/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests updated.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30569: Add a 'Prepare Backups' Stage to Rolling
Upgrade before ZooKeeper
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/#review70782
-----------------------------------------------------------
Ship it!
Nice!
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/30569/#comment116207>
This block still needs to be in the HIVE section. It's not backup, and it needs to be done before the restart.
- Nate Cole
On Feb. 3, 2015, 1:19 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30569/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 1:19 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9456
> https://issues.apache.org/jira/browse/AMBARI-9456
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There should be an explicit stage at the beginning of Rolling Upgrade called 'Prepare Backups' that does pre-upgrade steps for the following :
>
> - HBase
> - HDFS
> - Hive
> - Oozie
>
> As part of this task, we need to ensure that backups steps are removed from other stages (so that they are not duplicated).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 0d250d3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 28d0b1f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d878fee
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml cc8bd0a
>
> Diff: https://reviews.apache.org/r/30569/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests updated.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30569: Add a 'Prepare Backups' Stage to Rolling
Upgrade before ZooKeeper
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/#review70802
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 3, 2015, 6:19 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30569/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 6:19 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9456
> https://issues.apache.org/jira/browse/AMBARI-9456
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There should be an explicit stage at the beginning of Rolling Upgrade called 'Prepare Backups' that does pre-upgrade steps for the following :
>
> - HBase
> - HDFS
> - Hive
> - Oozie
>
> As part of this task, we need to ensure that backups steps are removed from other stages (so that they are not duplicated).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 0d250d3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 28d0b1f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d878fee
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml cc8bd0a
>
> Diff: https://reviews.apache.org/r/30569/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests updated.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30569: Add a 'Prepare Backups' Stage to Rolling
Upgrade before ZooKeeper
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/#review70805
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Feb. 3, 2015, 2:22 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30569/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 2:22 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9456
> https://issues.apache.org/jira/browse/AMBARI-9456
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There should be an explicit stage at the beginning of Rolling Upgrade called 'Prepare Backups' that does pre-upgrade steps for the following :
>
> - HBase
> - HDFS
> - Hive
> - Oozie
>
> As part of this task, we need to ensure that backups steps are removed from other stages (so that they are not duplicated).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 0d250d3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 28d0b1f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d878fee
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml cc8bd0a
>
> Diff: https://reviews.apache.org/r/30569/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests updated.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30569: Add a 'Prepare Backups' Stage to Rolling
Upgrade before ZooKeeper
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/#review70823
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 3, 2015, 2:22 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30569/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 2:22 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9456
> https://issues.apache.org/jira/browse/AMBARI-9456
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There should be an explicit stage at the beginning of Rolling Upgrade called 'Prepare Backups' that does pre-upgrade steps for the following :
>
> - HBase
> - HDFS
> - Hive
> - Oozie
>
> As part of this task, we need to ensure that backups steps are removed from other stages (so that they are not duplicated).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 0d250d3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 28d0b1f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d878fee
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml cc8bd0a
>
> Diff: https://reviews.apache.org/r/30569/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests updated.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30569: Add a 'Prepare Backups' Stage to Rolling
Upgrade before ZooKeeper
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 7:22 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Fixed HIVE pre-upgrade
Bugs: AMBARI-9456
https://issues.apache.org/jira/browse/AMBARI-9456
Repository: ambari
Description
-------
There should be an explicit stage at the beginning of Rolling Upgrade called 'Prepare Backups' that does pre-upgrade steps for the following :
- HBase
- HDFS
- Hive
- Oozie
As part of this task, we need to ensure that backups steps are removed from other stages (so that they are not duplicated).
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 0d250d3
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 28d0b1f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d878fee
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml cc8bd0a
Diff: https://reviews.apache.org/r/30569/diff/
Testing
-------
Manual testing.
Unit tests updated.
All tests pass.
Thanks,
Tom Beerbower
Re: Review Request 30569: Add a 'Prepare Backups' Stage to Rolling
Upgrade before ZooKeeper
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 3, 2015, 1:42 p.m., Jonathan Hurley wrote:
> > Ship It!
The only issue was the on Nate pointed out with Hive; it should go back into HIVE and I think we still need the 2 different manual tasks.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/#review70789
-----------------------------------------------------------
On Feb. 3, 2015, 1:19 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30569/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 1:19 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9456
> https://issues.apache.org/jira/browse/AMBARI-9456
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There should be an explicit stage at the beginning of Rolling Upgrade called 'Prepare Backups' that does pre-upgrade steps for the following :
>
> - HBase
> - HDFS
> - Hive
> - Oozie
>
> As part of this task, we need to ensure that backups steps are removed from other stages (so that they are not duplicated).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 0d250d3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 28d0b1f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d878fee
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml cc8bd0a
>
> Diff: https://reviews.apache.org/r/30569/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests updated.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30569: Add a 'Prepare Backups' Stage to Rolling
Upgrade before ZooKeeper
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/#review70789
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 3, 2015, 1:19 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30569/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 1:19 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9456
> https://issues.apache.org/jira/browse/AMBARI-9456
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There should be an explicit stage at the beginning of Rolling Upgrade called 'Prepare Backups' that does pre-upgrade steps for the following :
>
> - HBase
> - HDFS
> - Hive
> - Oozie
>
> As part of this task, we need to ensure that backups steps are removed from other stages (so that they are not duplicated).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 0d250d3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 28d0b1f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d878fee
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml cc8bd0a
>
> Diff: https://reviews.apache.org/r/30569/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests updated.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>