[GitHub] [accumulo] ctubbsii commented on a change in pull request #2106: Make LogReader more discoverable

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2106:
URL: https://github.com/apache/accumulo/pull/2106#discussion_r631913046



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogReader.java
##########
@@ -73,19 +77,37 @@
    * @param args
    *          - first argument is the file to print
    */
-  public static void main(String[] args) throws IOException {
+  public static void main(String[] args) throws Exception {
+    new LogReader().execute(args);
+  }
+
+  @Override
+  public String keyword() {
+    return "wal-info";
+  }
+
+  @Override
+  public String description() {
+    return "Prints WAL Info";
+  }
+
+  @SuppressFBWarnings(value = "DM_EXIT",
+      justification = "System.exit is fine here because it's a utility class executed by a main()")
+  @Override
+  public void execute(String[] args) throws Exception {
     Opts opts = new Opts();
-    opts.parseArgs(LogReader.class.getName(), args);
+    opts.parseArgs("accumulo wal-info", args);
+    if (opts.files.isEmpty()) {
+      System.err.println("No WAL files were given");
+      System.exit(1);
+    }

Review comment:
       This is okay, but I wonder if this will allow users to see the full usage. Is there a `--help` or `-?` option to show the usage, or if the command-line options are wrong, is there anyway for the user to see what the correct usage is? The code that this bit replaces did `new JCommander(opts).usage()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org