[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3606: [CARBONDATA-3681][CARBONDATA-3688] Add compressor name in data file name and change default compressor to ZSTD

[GitBox <gi...@apache.org>]

Indhumathi27 commented on a change in pull request #3606: [CARBONDATA-3681][CARBONDATA-3688] Add compressor name in data file name and change default compressor to ZSTD
URL: https://github.com/apache/carbondata/pull/3606#discussion_r382532147
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
 ##########
 @@ -409,11 +433,10 @@ public static String getTimeStampFromFileName(String carbonDataFileName) {
      * @return
      */
     public static Boolean compareCarbonFileTimeStamp(String fileName, Long timestamp) {
-      int lastIndexOfHyphen = fileName.lastIndexOf("-");
-      int lastIndexOfDot = fileName.lastIndexOf(".");
-      if (lastIndexOfHyphen > 0 && lastIndexOfDot > 0) {
-        return fileName.substring(fileName.lastIndexOf("-") + 1, fileName.lastIndexOf("."))
-            .equals(timestamp.toString());
+      int startIndex = fileName.lastIndexOf("-");
 
 Review comment:
   Suggest to use CarbonCommonConstants for "-". "."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services