You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/06/28 12:53:29 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1651: [CELEBORN-739] Rename HeartbeatResponse to HeartbeatFromWorkerResponse
AngersZhuuuu opened a new pull request, #1651:
URL: https://github.com/apache/incubator-celeborn/pull/1651
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Rename HeartbeatResponse to HeartbeatFromWorkerResponse
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1651: [CELEBORN-739] Rename HeartbeatResponse to HeartbeatFromWorkerResponse
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1651:
URL: https://github.com/apache/incubator-celeborn/pull/1651#issuecomment-1612346935
> I think no, the protobuf binary encoding format does not contains the message name
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1651: [CELEBORN-739] Rename HeartbeatResponse to HeartbeatFromWorkerResponse
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1651:
URL: https://github.com/apache/incubator-celeborn/pull/1651#issuecomment-1612438797
Thanks, merged to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1651: [CELEBORN-739] Rename HeartbeatResponse to HeartbeatFromWorkerResponse
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1651:
URL: https://github.com/apache/incubator-celeborn/pull/1651#issuecomment-1611346762
ping @waitinfuture @pan3793 @FMX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1651: [CELEBORN-739] Rename HeartbeatResponse to HeartbeatFromWorkerResponse
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1651:
URL: https://github.com/apache/incubator-celeborn/pull/1651#issuecomment-1611385117
I'm afraid change message name will cause compatibility issue. cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1651: [CELEBORN-739] Rename HeartbeatResponse to HeartbeatFromWorkerResponse
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1651: [CELEBORN-739] Rename HeartbeatResponse to HeartbeatFromWorkerResponse
URL: https://github.com/apache/incubator-celeborn/pull/1651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1651: [CELEBORN-739] Rename HeartbeatResponse to HeartbeatFromWorkerResponse
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1651:
URL: https://github.com/apache/incubator-celeborn/pull/1651#issuecomment-1611393131
> I'm afraid change message name will cause compatibility issue. cc @pan3793
I think no, the protobuf binary encoding format does not contains the message name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1651: [CELEBORN-739] Rename HeartbeatResponse to HeartbeatFromWorkerResponse
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1651:
URL: https://github.com/apache/incubator-celeborn/pull/1651#issuecomment-1612351241
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1651?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1651](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1651?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4d05a74) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/4c4e18b0d6e40b57326cc431fd79bbaf2c43353f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4c4e18b) will **decrease** coverage by `0.14%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
- Coverage 46.32% 46.18% -0.14%
==========================================
Files 161 161
Lines 9949 9949
Branches 957 957
==========================================
- Hits 4608 4594 -14
- Misses 5040 5052 +12
- Partials 301 303 +2
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...born/common/protocol/message/ControlMessages.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | `1.46% <0.00%> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1651/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org