You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/28 18:32:21 UTC

[GitHub] cckellogg commented on a change in pull request #2875: Hooked up secrets function api with secret function implementations

cckellogg commented on a change in pull request #2875: Hooked up secrets function api with secret function implementations
URL: https://github.com/apache/pulsar/pull/2875#discussion_r228759162
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeUtils.java
 ##########
 @@ -49,6 +50,8 @@
                                            Integer grpcPort,
                                            Long expectedHealthCheckInterval,
                                            String logConfigFile,
+                                           String secretsProviderClassName,
 
 Review comment:
   Can some docs be added to what the secretsProviderConfig could or does contain. Should the classname just go in the secretsProviderConfig  so there is only one variable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services