[jira] [Resolved] (SPARK-11163) Remove unnecessary addPendingTask calls in TaskSetManager.executorLost

["Kay Ousterhout (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-11163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Ousterhout resolved SPARK-11163.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.6.0

Issue resolved by pull request 9154
[https://github.com/apache/spark/pull/9154]

> Remove unnecessary addPendingTask calls in TaskSetManager.executorLost
> ----------------------------------------------------------------------
>
>                 Key: SPARK-11163
>                 URL: https://issues.apache.org/jira/browse/SPARK-11163
>             Project: Spark
>          Issue Type: Improvement
>          Components: Scheduler
>            Reporter: Kay Ousterhout
>            Assignee: Kay Ousterhout
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> The proposed commit removes unnecessary calls to addPendingTask in
> TaskSetManager.executorLost. These calls are unnecessary: for
> tasks that are still pending and haven't been launched, they're
> still in all of the correct pending lists, so calling addPendingTask
> has no effect. For tasks that are currently running (which may still be
> in the pending lists, depending on how they were scheduled), we call
> addPendingTask in handleFailedTask, so the calls at the beginning
> of executorLost are redundant.
> I think these calls are left over from when we re-computed the locality
> levels in addPendingTask; now that we call recomputeLocality separately,
> I don't think these are necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org