You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "Radeity (via GitHub)" <gi...@apache.org> on 2023/05/07 02:40:41 UTC
[GitHub] [incubator-hugegraph-computer] Radeity opened a new pull request, #238: Fix some typo errors in start-computer.sh
Radeity opened a new pull request, #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238
Fix some typo errors in `start-computer.sh` : )
**Brief changes:**
- (Spelling) Change `muse` to `must`.
- (Grammar) Add `must` before `not be`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin commented on pull request #238: fix: typo errors in start-computer.sh
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1540012262
> > may i ask for the right way to map these go packages to java class? I really want to go on exploring our codes!
>
> you can run [`master`/computer-k8s-operator/crd-generate/Makefile](https://github.com/apache/incubator-hugegraph-computer/blob/master/computer-k8s-operator/crd-generate/Makefile?rgh-link-date=2023-05-09T09%3A54%3A29Z): gen-all , it will generate [`master`/computer-k8s-operator/manifest/hugegraph-computer-crd.v1.yaml](https://github.com/apache/incubator-hugegraph-computer/blob/master/computer-k8s-operator/manifest/hugegraph-computer-crd.v1.yaml?rgh-link-date=2023-05-09T09%3A54%3A29Z) and [`master`/computer-k8s/schema/crd-schema.json](https://github.com/apache/incubator-hugegraph-computer/blob/master/computer-k8s/schema/crd-schema.json?rgh-link-date=2023-05-09T09%3A54%3A29Z)
@Radeity we do lack the doc in [computer](https://hugegraph.apache.org/docs/quickstart/hugegraph-computer/), if u pass this problem , could add a doc PR to improve it (Actually the first time I run it, I'm also confused 😿 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin commented on a diff in pull request #238: Fix some typo errors in start-computer.sh
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#discussion_r1186827519
##########
computer-dist/src/assembly/static/bin/start-computer.sh:
##########
@@ -76,22 +76,22 @@ parse_opts() {
case "$1" in
-c|--conf)
- check_empty "conf file not be empty" $2
+ check_empty "conf file must not be empty" $2
Review Comment:
maybe use “can't” is better？ （so as other typo）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] simon824 merged pull request #238: fix: typo errors in start-computer.sh
Posted by "simon824 (via GitHub)" <gi...@apache.org>.
simon824 merged PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin commented on pull request #238: Fix some typo errors in start-computer.sh
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1538547673
The ci always failed... any way to improve it? @coderzc
<img width="960" alt="image" src="https://user-images.githubusercontent.com/17706099/236862652-f6633e6d-b9a7-4de5-8387-60fc7afcf8b8.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] coderzc commented on pull request #238: fix: typo errors in start-computer.sh
Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1539781393
> BTW, I don't find the implementation class of JobObserver... I will be appreciated if you could guide me how to find it!
The JobObserver will be implemented by calling `KubernetesDriver.waitJobAsync`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] Radeity commented on pull request #238: fix: typo errors in start-computer.sh
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1540013755
>
> @Radeity we do lack the doc in [computer](https://hugegraph.apache.org/docs/quickstart/hugegraph-computer/), if u pass this problem , could add a doc PR to improve it (Actually the first time I run it, I'm also confused 😿 )
No problem, I'll try it later, I'm glad to help : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] coderzc commented on pull request #238: fix: typo errors in start-computer.sh
Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1539819176
> may i ask for the right way to map these go packages to java class? I really want to go on exploring our codes!
you can run https://github.com/apache/incubator-hugegraph-computer/blob/master/computer-k8s-operator/crd-generate/Makefile: gen-all , it will generate https://github.com/apache/incubator-hugegraph-computer/blob/master/computer-k8s-operator/manifest/hugegraph-computer-crd.v1.yaml and https://github.com/apache/incubator-hugegraph-computer/blob/master/computer-k8s/schema/crd-schema.json
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] codecov[bot] commented on pull request #238: Fix some typo errors in start-computer.sh
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1537395063
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/238?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#238](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/238?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ddfba4) into [master](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/commit/cc5a7e727d42b5139fc8f5c3bea9ce55a05c9263?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc5a7e7) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #238 +/- ##
=========================================
Coverage 85.83% 85.83%
Complexity 3232 3232
=========================================
Files 344 344
Lines 12072 12072
Branches 1087 1087
=========================================
Hits 10362 10362
+ Misses 1185 1184 -1
- Partials 525 526 +1
```
[see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/238/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin commented on a diff in pull request #238: Fix some typo errors in start-computer.sh
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#discussion_r1186827519
##########
computer-dist/src/assembly/static/bin/start-computer.sh:
##########
@@ -76,22 +76,22 @@ parse_opts() {
case "$1" in
-c|--conf)
- check_empty "conf file not be empty" $2
+ check_empty "conf file must not be empty" $2
Review Comment:
maybe use “can't” is better？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] Radeity commented on pull request #238: fix: typo errors in start-computer.sh
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1539425952
> The ci always failed (>10times)... any way to improve it? @coderzc
>
> <img alt="image" width="960" src="https://user-images.githubusercontent.com/17706099/236862652-f6633e6d-b9a7-4de5-8387-60fc7afcf8b8.png">
Hi, @imbajin, the error logs indicate that calling for `jobObserver.onJobStateChanged()` receive unexpected arg (status).
However, according to the UT codes, the only possible status change is from `INITIALIZING` to `RUNNING`, i'm a little confused, if the problem caused by unstable MiniKube environment, the probability of this happening is small, either.
BTW, I don't find the implementation class of `JobObserver`... I will be appreciated if you could guide me how to find it! Also, it seems that some classes are generated from `go`, such as `org.apache.hugegraph.computer.k8s.crd.model.ComputerJobSpec`, may i ask for the right way to map these go packages to java class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] Radeity commented on pull request #238: fix: typo errors in start-computer.sh
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1539808366
> The JobObserver will be implemented by calling KubernetesDriver.waitJobAsync
Get it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] Radeity commented on pull request #238: fix: typo errors in start-computer.sh
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1546601862
Hi, @imbajin , I find that `make gen-all` is needed only when someone want to develop and modify CRD or Controller, they have to generate and submit codes with newly generated yaml and json schema files.
Thus, for me, directly run `mvn install` can solve the problem, cuz java classes will be generated with existed json schema files and `jsonschema2pojo` plugin.
May i ask which type of doc do we need, a doc to describe code structures (the meaning of different modules) **OR** a doc to to tell how to build development environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] Radeity commented on pull request #238: fix: typo errors in start-computer.sh
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1548205451
> We need add building-doc first for normal devs, then we could add the details u mentioned (optional & enhancement)
Hi, @imbajin , thanks for your reply, I'll do it step by step as you mentioned.
> @coderzc could tell u the truth 👨🏻💻
And I've already confirmed with him, thanks again for your help @coderzc :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] Radeity commented on pull request #238: Fix some typo errors in start-computer.sh
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #238:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/238#issuecomment-1537417610
Hi, @imbajin , thanks for your comment, i've already changed `must not` to `can't`, also make some other tiny typo changes, PTAL : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org