[GitHub] [airflow] rolanddb opened a new pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError

[GitBox <gi...@apache.org>]

rolanddb opened a new pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError
URL: https://github.com/apache/airflow/pull/5880
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues:
     - https://issues.apache.org/jira/browse/AIRFLOW-5282
   
   ### Description
   
   This PR:
   * Adds a default _request_timeout in airflow.cfg, so that default installations will not hang indefinitely
   * Catches the errors in the scheduler, and retries scheduling the task, in a similar fashion to how ApiExcptions are caught. (https://github.com/apache/airflow/blob/46885ccdbc8618f295b8f986da95c1abbb85bb02/airflow/executors/kubernetes_executor.py#L800-L803)
   * Fixes a bug in the parsing of airflow.cfg. The notes state that a json dict is expected. This is parsed with `json.loads`, which returns a dict. But in the code, .iteritems() is called on this dict, which cannot work. .items() should be used instead.
   
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services