[GitHub] [druid] suneet-s commented on a change in pull request #10676: Allow client to configure batch ingestion task to wait to complete until segments are confirmed to be available by other

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #10676:
URL: https://github.com/apache/druid/pull/10676#discussion_r607434654



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java
##########
@@ -146,7 +151,7 @@
   @Nullable
   private final ClientCompactionTaskGranularitySpec granularitySpec;
   @Nullable
-  private final ParallelIndexTuningConfig tuningConfig;
+  private final CompactionTuningConfig tuningConfig;

Review comment:
       I think this change means that compaction jobs that are submitted with a `ParallelIndexTuningConfig` (using type = `index_parallel`) will start failing after this change - is this correct?
   
   If so, I think instead of introducing this as a breaking change, we can just add the Precondition check that you have in the `CompactionTuningConfig`  into the constructor for the compaction task.
   
   If this isn't a breaking change, I like that there's a separate tuningConfig for compaction tasks, so that in the future, this config can be more easily optimized.
   
   
   cc @maytasm Since I've seen you make some improvements around compaction recently




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org