You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/03/22 09:11:24 UTC
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/
-----------------------------------------------------------
(Updated March 22, 2013, 8:11 a.m.)
Review request for cloudstack, Kishan Kavala and Rohit Yadav.
Changes
-------
This patch also need to be committed to 4.0 branch.
Description
-------
The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
This addresses bug CLOUDSTACK-962.
Diffs
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 943c85f
usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
Diff: https://reviews.apache.org/r/8971/diff/
Testing
-------
The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
Thanks,
Wei Zhou
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/#review18260
-----------------------------------------------------------
Ship it!
Ship It!
- Kishan Kavala
On March 22, 2013, 9 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8971/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 9 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav.
>
>
> Description
> -------
>
> The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
>
> If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
>
> Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
>
> This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
> This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
> You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
>
>
> This addresses bug CLOUDSTACK-962.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 008c7c2
> server/src/com/cloud/user/dao/UserStatisticsDaoImpl.java fd7795a
> usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
>
> Diff: https://reviews.apache.org/r/8971/diff/
>
>
> Testing
> -------
>
> The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
>
> usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
> usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
> usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
> usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/#review20600
-----------------------------------------------------------
Commit 8f7a51ee5f5d745026d51b9ca3b2746a39f00bf2 in branch refs/heads/ui-vpc-redesign from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8f7a51e ]
CLOUDSTACK-962: Because of the same reason to this (CLOUDSTACK-685)
https://reviews.apache.org/r/11157/
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On March 22, 2013, 9 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8971/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 9 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav.
>
>
> Description
> -------
>
> The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
>
> If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
>
> Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
>
> This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
> This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
> You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
>
>
> This addresses bug CLOUDSTACK-962.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 008c7c2
> server/src/com/cloud/user/dao/UserStatisticsDaoImpl.java fd7795a
> usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
>
> Diff: https://reviews.apache.org/r/8971/diff/
>
>
> Testing
> -------
>
> The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
>
> usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
> usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
> usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
> usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/#review20595
-----------------------------------------------------------
Commit 8f7a51ee5f5d745026d51b9ca3b2746a39f00bf2 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8f7a51e ]
CLOUDSTACK-962: Because of the same reason to this (CLOUDSTACK-685)
https://reviews.apache.org/r/11157/
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On March 22, 2013, 9 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8971/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 9 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav.
>
>
> Description
> -------
>
> The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
>
> If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
>
> Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
>
> This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
> This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
> You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
>
>
> This addresses bug CLOUDSTACK-962.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 008c7c2
> server/src/com/cloud/user/dao/UserStatisticsDaoImpl.java fd7795a
> usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
>
> Diff: https://reviews.apache.org/r/8971/diff/
>
>
> Testing
> -------
>
> The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
>
> usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
> usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
> usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
> usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/#review18256
-----------------------------------------------------------
Commit 5ac59fbecbae069ab46048e9a73a6f7b8fb2d4b1 in branch refs/heads/4.0 from Kishan Kavala <ki...@cloud.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5ac59fb ]
CLOUDSTACK-962: CloudStack usage server didn't store data to cloud_usage in correct time
- ASF Subversion and Git Services
On March 22, 2013, 9 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8971/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 9 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav.
>
>
> Description
> -------
>
> The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
>
> If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
>
> Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
>
> This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
> This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
> You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
>
>
> This addresses bug CLOUDSTACK-962.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 008c7c2
> server/src/com/cloud/user/dao/UserStatisticsDaoImpl.java fd7795a
> usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
>
> Diff: https://reviews.apache.org/r/8971/diff/
>
>
> Testing
> -------
>
> The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
>
> usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
> usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
> usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
> usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/#review20634
-----------------------------------------------------------
Commit 3fa8fda37c8b9fac1e38b57d28d23917106fe02b in branch refs/heads/object_store from Edison Su <su...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3fa8fda ]
CLOUDSTACK-962: Because of the same reason to this (CLOUDSTACK-685)
https://reviews.apache.org/r/11157/
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On March 22, 2013, 9 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8971/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 9 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav.
>
>
> Description
> -------
>
> The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
>
> If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
>
> Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
>
> This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
> This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
> You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
>
>
> This addresses bug CLOUDSTACK-962.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 008c7c2
> server/src/com/cloud/user/dao/UserStatisticsDaoImpl.java fd7795a
> usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
>
> Diff: https://reviews.apache.org/r/8971/diff/
>
>
> Testing
> -------
>
> The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
>
> usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
> usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
> usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
> usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/#review20590
-----------------------------------------------------------
Commit e6af3bf112f33a8e02eb6d964ce799e6f30447e0 in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e6af3bf ]
CLOUDSTACK-962: Because of the same reason to this (CLOUDSTACK-685)
https://reviews.apache.org/r/11157/
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On March 22, 2013, 9 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8971/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 9 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav.
>
>
> Description
> -------
>
> The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
>
> If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
>
> Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
>
> This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
> This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
> You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
>
>
> This addresses bug CLOUDSTACK-962.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 008c7c2
> server/src/com/cloud/user/dao/UserStatisticsDaoImpl.java fd7795a
> usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
>
> Diff: https://reviews.apache.org/r/8971/diff/
>
>
> Testing
> -------
>
> The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
>
> usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
> usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
> usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
> usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/
-----------------------------------------------------------
(Updated March 22, 2013, 9 a.m.)
Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav.
Description
-------
The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
This addresses bug CLOUDSTACK-962.
Diffs (updated)
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 008c7c2
server/src/com/cloud/user/dao/UserStatisticsDaoImpl.java fd7795a
usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
Diff: https://reviews.apache.org/r/8971/diff/
Testing
-------
The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
Thanks,
Wei Zhou
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/
-----------------------------------------------------------
(Updated March 22, 2013, 8:58 a.m.)
Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav.
Changes
-------
update patch for 4.0 branch
Description
-------
The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
This addresses bug CLOUDSTACK-962.
Diffs (updated)
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 008c7c2
server/src/com/cloud/user/dao/UserStatisticsDaoImpl.java fd7795a
usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
Diff: https://reviews.apache.org/r/8971/diff/
Testing
-------
The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
Thanks,
Wei Zhou
Re: Review Request: (CLOUDSTACK-962) CloudStack usage server didn't store
data to cloud_usage in correct time
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8971/
-----------------------------------------------------------
(Updated March 22, 2013, 8:25 a.m.)
Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav.
Changes
-------
including jzb for the patch inclusion in the 4.0 branch
Description
-------
The usage sever does not handle data in the correct time. For example, it regards the data traffic between 9:15-9:30 as the data traffic between 9:30-9:45.
If the interval is set to 1440(this means usge server calculate the data from 0:00-23:59:59 at predefined time). The usage server regards the data traffic between the server starting time(such as 13:00) to the next day(13:00) as the data traffic between 0:00 an 23:59:59.
Another problem is, when the usage.stats.job.aggregation.range is set to N( for example, 15), the usage job handle the data every N+1 minutes( for example 16).
This is a patch for this issue (all details are described here: https://issues.apache.org/jira/browse/CLOUDSTACK-962 ).
This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1.
You can get from: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681
This addresses bug CLOUDSTACK-962.
Diffs
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 943c85f
usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14
Diff: https://reviews.apache.org/r/8971/diff/
Testing
-------
The patch is tested in CloudStack Virtual Router environment (Advanced Networking, not Basic Networking).
usage.stats.job.aggregation.range = 5, the usage server collects data every 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at 13:10:00).
usage.stats.job.aggregation.range = 15, the usage server collects data every 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at 13:15:00).
usage.stats.job.aggregation.range = 60, the usage server collects data every hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10).
usage.stats.job.aggregation.range = 1440, the usage server collects data every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30).
Thanks,
Wei Zhou