You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/01 23:46:45 UTC
[GitHub] [airflow] kaxil opened a new issue #12748: Code Coverage is Broken
kaxil opened a new issue #12748:
URL: https://github.com/apache/airflow/issues/12748
https://codecov.io/github/apache/airflow?branch=master CodeCov code-coverage is broken on Master. It wasn't great but still useful to check which sections needed lacks tests.
cc @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #12748: Code Coverage is Broken
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #12748:
URL: https://github.com/apache/airflow/issues/12748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12748: Code Coverage is Broken
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12748:
URL: https://github.com/apache/airflow/issues/12748#issuecomment-736909534
Oh yeah. nobody noticed for 6 months ;) . I think It actually works but in a weird way. I will look at that after we get RC out unless someone does it first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12748: Code Coverage is Broken
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12748:
URL: https://github.com/apache/airflow/issues/12748#issuecomment-826571603
I think as of April after some fixes, the coverage is back on track:
Particularly: https://github.com/apache/airflow/commit/1dfbb8d2031cb8a3e95e4bf91aa478857c5c3a85 helped with that because master merges started to succeed and "master merge" builds are the ones contributing "full coverage" information
Example:
* s3 is 94%: https://codecov.io/gh/apache/airflow/src/master/airflow/providers/amazon/aws/hooks/s3.py
* overall coverage is 89.97%
I looked at the coverage graphs (the sunburst chart is pretty usefule) and there are a few interesting things - maybe we would like to address them:
* Kubernetes executor has surprisingly low 64% https://codecov.io/gh/apache/airflow/src/master/airflow/executors/kubernetes_executor.py - looks like some of the "flush/end" code is not tested.
* Task command has a few missing parts: https://codecov.io/gh/apache/airflow/src/master/airflow/cli/commands/task_command.py (77%)
* There are quite a number of untested views: https://codecov.io/gh/apache/airflow/src/master/airflow/www/views.py 80%
* Kuberentes refresh_config has untested method https://codecov.io/gh/apache/airflow/src/master/airflow/kubernetes/refresh_config.py 75%
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12748: Code Coverage is Broken
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12748:
URL: https://github.com/apache/airflow/issues/12748#issuecomment-826585550
Created some good-first-issues for those: #15523 #15524 #15525 #15526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on issue #12748: Code Coverage is Broken
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on issue #12748:
URL: https://github.com/apache/airflow/issues/12748#issuecomment-769424565
@kaxil @potiuk @ashb
I was looking at this the other day when Ash shared the code coverage report. Is there an immediate next step here? If so, should we move to a different milestone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #12748: Code Coverage is Broken
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #12748:
URL: https://github.com/apache/airflow/issues/12748#issuecomment-799533690
code coverage suppose to show the code lines that are missing test coverage isn’t it?
for example https://codecov.io/gh/apache/airflow/tree/master/airflow/providers/amazon/aws/hooks
I can see that s3.py has 31.68%
but when I click on the file I can’t see what lines don’t have coverage. I get GitHub API: Forbidden
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #12748: Code Coverage is Broken
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #12748:
URL: https://github.com/apache/airflow/issues/12748#issuecomment-826728229
Awesome, thanks @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #12748: Code Coverage is Broken
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #12748:
URL: https://github.com/apache/airflow/issues/12748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org