You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2024/06/11 12:03:27 UTC
[PR] [Fix](analyzer) add ownership flag to Field's TokenStream value and Analyzer's Reader [doris-thirdparty]
airborne12 opened a new pull request, #222:
URL: https://github.com/apache/doris-thirdparty/pull/222
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](analyzer) add ownership flag to Field's TokenStream value and Analyzer's Reader [doris-thirdparty]
Posted by "qidaye (via GitHub)" <gi...@apache.org>.
qidaye merged PR #222:
URL: https://github.com/apache/doris-thirdparty/pull/222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](analyzer) add ownership flag to Field's TokenStream value and Analyzer's Reader [doris-thirdparty]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #222:
URL: https://github.com/apache/doris-thirdparty/pull/222#discussion_r1635671144
##########
src/core/CLucene/document/Field.cpp:
##########
@@ -340,7 +341,10 @@ void Field::_resetValue() {
} else if (valueType & VALUE_BINARY) {
ValueArray<uint8_t>* v = static_cast<ValueArray<uint8_t>*>(fieldsData);
_CLDELETE(v);
- }
+ } else if (valueType & VALUE_TOKENSTREAM && ownStream) {
Review Comment:
if add here will change other VALUE_TOKENSTREAM Field logic in cluecen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org