You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/10/19 20:38:36 UTC

Review Request 39448: Upgrade path on ORA 1.6.1 -> 2.0.1 -> 2.1.1

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39448/
-----------------------------------------------------------

Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-13478
    https://issues.apache.org/jira/browse/AMBARI-13478


Repository: ambari


Description
-------

We ignore case on trying find if FK exists but use the user supplied fk name in ALTER query.
This method should return the fk name found if at all.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java cd47252 
  ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java 05856b3 

Diff: https://reviews.apache.org/r/39448/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 39448: Upgrade path on ORA 1.6.1 -> 2.0.1 -> 2.1.1

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39448/#review103259
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Жов. 19, 2015, 9:38 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39448/
> -----------------------------------------------------------
> 
> (Updated Жов. 19, 2015, 9:38 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-13478
>     https://issues.apache.org/jira/browse/AMBARI-13478
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We ignore case on trying find if FK exists but use the user supplied fk name in ALTER query.
> This method should return the fk name found if at all.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java cd47252 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java 05856b3 
> 
> Diff: https://reviews.apache.org/r/39448/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 39448: Upgrade path on ORA 1.6.1 -> 2.0.1 -> 2.1.1

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39448/
-----------------------------------------------------------

(Updated Окт. 22, 2015, 5:30 п.п.)


Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-13478
    https://issues.apache.org/jira/browse/AMBARI-13478


Repository: ambari


Description
-------

We ignore case on trying find if FK exists but use the user supplied fk name in ALTER query.
This method should return the fk name found if at all.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java cd47252 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 12a1f44 
  ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java 05856b3 

Diff: https://reviews.apache.org/r/39448/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen