You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Christian P. MOMON (JIRA)" <ji...@apache.org> on 2015/04/30 05:06:05 UTC

[jira] [Commented] (LANG-1123) Unit test FastDatePrinterTimeZonesTest needs a timezone set

    [ https://issues.apache.org/jira/browse/LANG-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520761#comment-14520761 ] 

Christian P. MOMON commented on LANG-1123:
------------------------------------------

LANG-1123 bug appears now because it was hidden by LANG-916 bug.

> Unit test FastDatePrinterTimeZonesTest needs a timezone set
> -----------------------------------------------------------
>
>                 Key: LANG-1123
>                 URL: https://issues.apache.org/jira/browse/LANG-1123
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.time.*
>         Environment: Java 6, timezone is "Europe/Paris" (GMT/UTC +01:00), GNU/Linux.
>            Reporter: Christian P. MOMON
>            Priority: Blocker
>         Attachments: LANG-1123-fix-git.patch
>
>
> In file :
> {noformat}
> src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java
> {noformat}
> The unit test testCalendarTimezoneRespected set a timezone for the expectedValue but none for the actualValue. Because the actualValue use always the default timezone, then It has to fail.
> Actually, there is no fail because of a bug in FastDatePrinter.format() method (see LANG-916).
> When applying the LANG-916 patch, the unit test flood more than 600 failed:
> {noformat}
> cpm > mvn test
> Failed tests:
> [...]
>   FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[2:19PM EDT]> but was:<[6:19PM UTC]>
>   FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[2:19PM AST]> but was:<[6:19PM UTC]>
>   FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[12:19PM MDT]> but was:<[6:19PM UTC]>
>   FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[1:19PM ACT]> but was:<[6:19PM UTC]>
> [...]
> Tests run: 3544, Failures: 617, Errors: 0, Skipped: 5
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)