[GitHub] [superset] Antonio-RiveroMartnez commented on pull request #24580: feat(database): Database Filtering via custom configuration

["Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>]

Antonio-RiveroMartnez commented on PR #24580:
URL: https://github.com/apache/superset/pull/24580#issuecomment-1622223088

   > Could you provide some scenarios where you would use this? I also wonder if this should be generalized for all entity types.
   > 
   > Additionally I’m not saying I’m a supporter of Monkey Patching, but we should be cognizant that sometimes the method is used to relax (as opposed to further restrict) filters whereas this approach only addresses the later.
   
   There might be cases where I have a given database that I want to make visible/hidden to my users based on a `Feature Flag`. Right now, our options would be overriding the entire DatabaseRestApi or Monkey Patch it, with this change we extend the options we have, we can define our custom filter method in the config  and get it applied it to my responses in a easy way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org