You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Cheng Pan <pa...@gmail.com> on 2023/09/15 03:31:10 UTC
[VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Hi IPMC,
This is a call for a vote to release Apache Celeborn (Incubating)
0.3.1-incubating-rc2
The Apache Celeborn community has voted on and approved a proposal to
release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
We now kindly request the Incubator PMC members review and vote on this
incubator release.
celeborn@dev vote thread:
https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
celeborn@dev vote result thread:
https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
The git tag to be voted upon:
https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
The git commit hash:
7ec5596748af49ef9cb429d08550e89d94d5cc74
The source and binary artifacts can be found at:
https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
The staging repo:
https://repository.apache.org/content/repositories/orgapacheceleborn-1039
Fingerprint of the PGP key release artifacts are signed with:
8FC8075E1FDC303276C676EE8001952629BCC75D
My public key to verify signatures can be found in:
https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
The vote will be open for at least 72 hours or until the necessary
number of votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and the reason)
Checklist for release:
https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
Steps to validate the release:
https://www.apache.org/info/verification.html
Instructions for making binary artifacts from source:
build/make-distribution.sh --release
Thanks,
Cheng Pan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by keyong zhou <wa...@gmail.com>.
+1 (non-binding)
I checked
- git commit hash is correct.
- links are valid.
- "incubating" is in the name.
- PGP keys are good.
- hashes are correct.
- LICENSE looks good.
- NOTICE looks good.
- DISCLAIMER exists.
- build success from source code (macOS). ``` ./build/make-distribution.sh
--release ```
Thanks,
Keyong Zhou
Cheng Pan <pa...@gmail.com> 于2023年9月15日周五 18:49写道:
> Hi, Duo,
>
> Thanks for voting and verification.
>
> > 'mvn test -Pflink-1.17', I'm not sure whether this is the correct
>
> it probably works, it’s recommended to use `build/mvn` instead of bare
> `mvn` to build and test, which will use or download the `mvn` with the
> exact `maven.version` declared in `pom.xml`.
>
> the community is exploring migrating the building system to sbt, the sbt
> building doc is located at
> https://celeborn.apache.org/docs/latest/developers/sbt/
>
> Thanks,
> Cheng Pan
>
>
> > On Sep 15, 2023, at 18:17, 张铎(Duo Zhang) <pa...@gmail.com> wrote:
> >
> > +1 binding
> >
> > Checked sigs and sums: Matched
> > LICENSE and NOTICE: OK
> > DISCLAIMER: In place
> > Built from source:
> > ‘./build/make-distribution.sh -Pflink-1.17’, successfully generated
> > the tarball
> > Run UTs:
> > 'mvn test -Pflink-1.17', I'm not sure whether this is the correct
> > way as the README does not mention how to run tests but anway, we have
> > run several UTs and finally the mvn command passed without any error.
> >
> > Thanks.
> >
> > Cheng Pan <pa...@gmail.com> 于2023年9月15日周五 11:57写道:
> >>
> >> Hi IPMC,
> >>
> >> This is a call for a vote to release Apache Celeborn (Incubating)
> >> 0.3.1-incubating-rc2
> >>
> >> The Apache Celeborn community has voted on and approved a proposal to
> >> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
> >> We now kindly request the Incubator PMC members review and vote on this
> >> incubator release.
> >>
> >> celeborn@dev vote thread:
> >> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
> >>
> >> celeborn@dev vote result thread:
> >> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
> >>
> >> The git tag to be voted upon:
> >>
> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
> >>
> >> The git commit hash:
> >> 7ec5596748af49ef9cb429d08550e89d94d5cc74
> >>
> >> The source and binary artifacts can be found at:
> >>
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
> >>
> >> The staging repo:
> >>
> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
> >>
> >> Fingerprint of the PGP key release artifacts are signed with:
> >> 8FC8075E1FDC303276C676EE8001952629BCC75D
> >>
> >> My public key to verify signatures can be found in:
> >> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> >>
> >> The vote will be open for at least 72 hours or until the necessary
> >> number of votes are reached.
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove (and the reason)
> >>
> >> Checklist for release:
> >>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >>
> >> Steps to validate the release:
> >> https://www.apache.org/info/verification.html
> >>
> >> Instructions for making binary artifacts from source:
> >> build/make-distribution.sh --release
> >>
> >> Thanks,
> >> Cheng Pan
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: general-help@incubator.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by Cheng Pan <pa...@gmail.com>.
Hi, Duo,
Thanks for voting and verification.
> 'mvn test -Pflink-1.17', I'm not sure whether this is the correct
it probably works, it’s recommended to use `build/mvn` instead of bare `mvn` to build and test, which will use or download the `mvn` with the exact `maven.version` declared in `pom.xml`.
the community is exploring migrating the building system to sbt, the sbt building doc is located at https://celeborn.apache.org/docs/latest/developers/sbt/
Thanks,
Cheng Pan
> On Sep 15, 2023, at 18:17, 张铎(Duo Zhang) <pa...@gmail.com> wrote:
>
> +1 binding
>
> Checked sigs and sums: Matched
> LICENSE and NOTICE: OK
> DISCLAIMER: In place
> Built from source:
> ‘./build/make-distribution.sh -Pflink-1.17’, successfully generated
> the tarball
> Run UTs:
> 'mvn test -Pflink-1.17', I'm not sure whether this is the correct
> way as the README does not mention how to run tests but anway, we have
> run several UTs and finally the mvn command passed without any error.
>
> Thanks.
>
> Cheng Pan <pa...@gmail.com> 于2023年9月15日周五 11:57写道:
>>
>> Hi IPMC,
>>
>> This is a call for a vote to release Apache Celeborn (Incubating)
>> 0.3.1-incubating-rc2
>>
>> The Apache Celeborn community has voted on and approved a proposal to
>> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
>> We now kindly request the Incubator PMC members review and vote on this
>> incubator release.
>>
>> celeborn@dev vote thread:
>> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
>>
>> celeborn@dev vote result thread:
>> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
>>
>> The git tag to be voted upon:
>> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
>>
>> The git commit hash:
>> 7ec5596748af49ef9cb429d08550e89d94d5cc74
>>
>> The source and binary artifacts can be found at:
>> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
>>
>> The staging repo:
>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
>>
>> Fingerprint of the PGP key release artifacts are signed with:
>> 8FC8075E1FDC303276C676EE8001952629BCC75D
>>
>> My public key to verify signatures can be found in:
>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>>
>> The vote will be open for at least 72 hours or until the necessary
>> number of votes are reached.
>>
>> Please vote accordingly:
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and the reason)
>>
>> Checklist for release:
>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>>
>> Steps to validate the release:
>> https://www.apache.org/info/verification.html
>>
>> Instructions for making binary artifacts from source:
>> build/make-distribution.sh --release
>>
>> Thanks,
>> Cheng Pan
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
+1 binding
Checked sigs and sums: Matched
LICENSE and NOTICE: OK
DISCLAIMER: In place
Built from source:
‘./build/make-distribution.sh -Pflink-1.17’, successfully generated
the tarball
Run UTs:
'mvn test -Pflink-1.17', I'm not sure whether this is the correct
way as the README does not mention how to run tests but anway, we have
run several UTs and finally the mvn command passed without any error.
Thanks.
Cheng Pan <pa...@gmail.com> 于2023年9月15日周五 11:57写道:
>
> Hi IPMC,
>
> This is a call for a vote to release Apache Celeborn (Incubating)
> 0.3.1-incubating-rc2
>
> The Apache Celeborn community has voted on and approved a proposal to
> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
> celeborn@dev vote thread:
> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
>
> celeborn@dev vote result thread:
> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
>
> The git tag to be voted upon:
> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
>
> The git commit hash:
> 7ec5596748af49ef9cb429d08550e89d94d5cc74
>
> The source and binary artifacts can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
>
> Fingerprint of the PGP key release artifacts are signed with:
> 8FC8075E1FDC303276C676EE8001952629BCC75D
>
> My public key to verify signatures can be found in:
> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>
> The vote will be open for at least 72 hours or until the necessary
> number of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and the reason)
>
> Checklist for release:
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> Steps to validate the release:
> https://www.apache.org/info/verification.html
>
> Instructions for making binary artifacts from source:
> build/make-distribution.sh --release
>
> Thanks,
> Cheng Pan
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by Cheng Pan <pa...@gmail.com>.
Thanks, Duo, will have a try.
Thanks,
Cheng Pan
> On Sep 19, 2023, at 19:30, 张铎(Duo Zhang) <pa...@gmail.com> wrote:
>
> I checked the pom for spark-3-shaded
>
> https://github.com/apache/incubator-celeborn/blob/main/client-spark/spark-3-shaded/pom.xml
>
> You could try adding these transformers to the shade plugin to see if it helps
>
> <transformers>
> <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer">
> </transformer>
> <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
> <addHeader>false</addHeader>
> </transformer>
> </transformers>
>
> Cheng Pan <pa...@gmail.com> 于2023年9月19日周二 19:17写道:
>>
>> Hi PJ Fanning,
>>
>> Thanks for pointing out this issue, it was considered but seems broken recently, unfortunately.
>>
>> The proposed NOTICE and LICENSE files are under [1], would you mind taking a look? If it's OK, I’m going to investigate and fix the packaging issue then.
>>
>> Given it’s a license issue, I suppose this RC has failed, but it would be nice if you could help to check if other things are OK before starting the next RC.
>>
>> [1] https://github.com/apache/incubator-celeborn/tree/main/client-spark/spark-3-shaded/src/main/resources/META-INF
>>
>> Thanks,
>> Cheng Pan
>>
>>
>>> On Sep 19, 2023, at 18:38, PJ Fanning <fa...@apache.org> wrote:
>>>
>>> I have some concerns over the jars that are part of the release.
>>>
>>> I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in
>>>
>>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/
>>>
>>> The jar has separate META-INF LICENSE and LICENSE.txt. Likewise for
>>> NOTICE and NOTICE.txt.
>>>
>>> The NOTICE.txt seems to be from Commons Lang.
>>>
>>> The jar contains classes from other projects (including non-ASF
>>> projects like guava) but there appears to be no acknowledgement of
>>> this in the META-INF LICENSE/NOTICE files.
>>>
>>> Example file:
>>> org/apache/celeborn/shaded/com/google/common/base/Ascii.class
>>>
>>> I checked celeborn-client-flink-1.17-shaded_2.12-0.3.1-incubating.jar
>>> and it has similar issues.
>>>
>>> Could you fix it so that these celeborn jars have only one LICENSE and
>>> NOTICE file and the LICENSE and NOTICE should acknowledge all the
>>> non-Celeborn classes that are bundled?
>>>
>>> I'd be interested in other people's interpretation here but I think
>>> the licensing in the jars is not correct.
>>>
>>>
>>>
>>> On Fri, 15 Sept 2023 at 05:03, Cheng Pan <pa...@gmail.com> wrote:
>>>>
>>>> Hi IPMC,
>>>>
>>>> This is a call for a vote to release Apache Celeborn (Incubating)
>>>> 0.3.1-incubating-rc2
>>>>
>>>> The Apache Celeborn community has voted on and approved a proposal to
>>>> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
>>>> We now kindly request the Incubator PMC members review and vote on this
>>>> incubator release.
>>>>
>>>> celeborn@dev vote thread:
>>>> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
>>>>
>>>> celeborn@dev vote result thread:
>>>> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
>>>>
>>>> The git tag to be voted upon:
>>>> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
>>>>
>>>> The git commit hash:
>>>> 7ec5596748af49ef9cb429d08550e89d94d5cc74
>>>>
>>>> The source and binary artifacts can be found at:
>>>> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
>>>>
>>>> The staging repo:
>>>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
>>>>
>>>> Fingerprint of the PGP key release artifacts are signed with:
>>>> 8FC8075E1FDC303276C676EE8001952629BCC75D
>>>>
>>>> My public key to verify signatures can be found in:
>>>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>>>>
>>>> The vote will be open for at least 72 hours or until the necessary
>>>> number of votes are reached.
>>>>
>>>> Please vote accordingly:
>>>>
>>>> [ ] +1 approve
>>>> [ ] +0 no opinion
>>>> [ ] -1 disapprove (and the reason)
>>>>
>>>> Checklist for release:
>>>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>>>>
>>>> Steps to validate the release:
>>>> https://www.apache.org/info/verification.html
>>>>
>>>> Instructions for making binary artifacts from source:
>>>> build/make-distribution.sh --release
>>>>
>>>> Thanks,
>>>> Cheng Pan
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
I checked the pom for spark-3-shaded
https://github.com/apache/incubator-celeborn/blob/main/client-spark/spark-3-shaded/pom.xml
You could try adding these transformers to the shade plugin to see if it helps
<transformers>
<transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer">
</transformer>
<transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
<addHeader>false</addHeader>
</transformer>
</transformers>
Cheng Pan <pa...@gmail.com> 于2023年9月19日周二 19:17写道:
>
> Hi PJ Fanning,
>
> Thanks for pointing out this issue, it was considered but seems broken recently, unfortunately.
>
> The proposed NOTICE and LICENSE files are under [1], would you mind taking a look? If it's OK, I’m going to investigate and fix the packaging issue then.
>
> Given it’s a license issue, I suppose this RC has failed, but it would be nice if you could help to check if other things are OK before starting the next RC.
>
> [1] https://github.com/apache/incubator-celeborn/tree/main/client-spark/spark-3-shaded/src/main/resources/META-INF
>
> Thanks,
> Cheng Pan
>
>
> > On Sep 19, 2023, at 18:38, PJ Fanning <fa...@apache.org> wrote:
> >
> > I have some concerns over the jars that are part of the release.
> >
> > I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in
> >
> > https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/
> >
> > The jar has separate META-INF LICENSE and LICENSE.txt. Likewise for
> > NOTICE and NOTICE.txt.
> >
> > The NOTICE.txt seems to be from Commons Lang.
> >
> > The jar contains classes from other projects (including non-ASF
> > projects like guava) but there appears to be no acknowledgement of
> > this in the META-INF LICENSE/NOTICE files.
> >
> > Example file:
> > org/apache/celeborn/shaded/com/google/common/base/Ascii.class
> >
> > I checked celeborn-client-flink-1.17-shaded_2.12-0.3.1-incubating.jar
> > and it has similar issues.
> >
> > Could you fix it so that these celeborn jars have only one LICENSE and
> > NOTICE file and the LICENSE and NOTICE should acknowledge all the
> > non-Celeborn classes that are bundled?
> >
> > I'd be interested in other people's interpretation here but I think
> > the licensing in the jars is not correct.
> >
> >
> >
> > On Fri, 15 Sept 2023 at 05:03, Cheng Pan <pa...@gmail.com> wrote:
> >>
> >> Hi IPMC,
> >>
> >> This is a call for a vote to release Apache Celeborn (Incubating)
> >> 0.3.1-incubating-rc2
> >>
> >> The Apache Celeborn community has voted on and approved a proposal to
> >> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
> >> We now kindly request the Incubator PMC members review and vote on this
> >> incubator release.
> >>
> >> celeborn@dev vote thread:
> >> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
> >>
> >> celeborn@dev vote result thread:
> >> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
> >>
> >> The git tag to be voted upon:
> >> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
> >>
> >> The git commit hash:
> >> 7ec5596748af49ef9cb429d08550e89d94d5cc74
> >>
> >> The source and binary artifacts can be found at:
> >> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
> >>
> >> The staging repo:
> >> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
> >>
> >> Fingerprint of the PGP key release artifacts are signed with:
> >> 8FC8075E1FDC303276C676EE8001952629BCC75D
> >>
> >> My public key to verify signatures can be found in:
> >> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> >>
> >> The vote will be open for at least 72 hours or until the necessary
> >> number of votes are reached.
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove (and the reason)
> >>
> >> Checklist for release:
> >> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >>
> >> Steps to validate the release:
> >> https://www.apache.org/info/verification.html
> >>
> >> Instructions for making binary artifacts from source:
> >> build/make-distribution.sh --release
> >>
> >> Thanks,
> >> Cheng Pan
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: general-help@incubator.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by Cheng Pan <pa...@gmail.com>.
Thanks for the advice, will update soon.
Thanks,
Cheng Pan
> On Sep 19, 2023, at 20:11, PJ Fanning <fa...@apache.org> wrote:
>
> I think it would be simpler to use the standard protobuf license. Just
> one file, including its copyright.
>
> https://github.com/protocolbuffers/protobuf/blob/main/LICENSE
>
> On Tue, 19 Sept 2023 at 12:45, Cheng Pan <pa...@gmail.com> wrote:
>>
>> PJ Fanning, both LICENSE-BSD-3.txt and LICENSE-BSD-3.txt are applied to protobuf-java, it was mentioned at the end of client-spark/spark-3-shaded/LICENSE, please let me know if you have a better idea of how to document clearly.
>>
>>
>>> BSD 3-clause
>>> See license/LICENSE-BSD-3.txt for details.
>>> ------------
>>> See license/LICENSE-protobuf.txt for details.
>>> com.google.protobuf:protobuf-java
>>
>> Thanks,
>> Cheng Pan
>>
>>
>>> On Sep 19, 2023, at 19:32, PJ Fanning <fa...@apache.org> wrote:
>>>
>>> I'll have a look around to see if there are other issues.
>>>
>>> With the BSD license mentioned in the client-spark/spark-3-shaded
>>> LICENSE, could it be adjusted to say which libs it applies to?
>>>
>>> https://github.com/apache/incubator-celeborn/blob/main/client-spark/spark-3-shaded/src/main/resources/META-INF/LICENSE
>>>
>>> On Tue, 19 Sept 2023 at 12:18, Cheng Pan <pa...@gmail.com> wrote:
>>>>
>>>> Hi PJ Fanning,
>>>>
>>>> Thanks for pointing out this issue, it was considered but seems broken recently, unfortunately.
>>>>
>>>> The proposed NOTICE and LICENSE files are under [1], would you mind taking a look? If it's OK, I’m going to investigate and fix the packaging issue then.
>>>>
>>>> Given it’s a license issue, I suppose this RC has failed, but it would be nice if you could help to check if other things are OK before starting the next RC.
>>>>
>>>> [1] https://github.com/apache/incubator-celeborn/tree/main/client-spark/spark-3-shaded/src/main/resources/META-INF
>>>>
>>>> Thanks,
>>>> Cheng Pan
>>>>
>>>>
>>>>> On Sep 19, 2023, at 18:38, PJ Fanning <fa...@apache.org> wrote:
>>>>>
>>>>> I have some concerns over the jars that are part of the release.
>>>>>
>>>>> I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in
>>>>>
>>>>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/
>>>>>
>>>>> The jar has separate META-INF LICENSE and LICENSE.txt. Likewise for
>>>>> NOTICE and NOTICE.txt.
>>>>>
>>>>> The NOTICE.txt seems to be from Commons Lang.
>>>>>
>>>>> The jar contains classes from other projects (including non-ASF
>>>>> projects like guava) but there appears to be no acknowledgement of
>>>>> this in the META-INF LICENSE/NOTICE files.
>>>>>
>>>>> Example file:
>>>>> org/apache/celeborn/shaded/com/google/common/base/Ascii.class
>>>>>
>>>>> I checked celeborn-client-flink-1.17-shaded_2.12-0.3.1-incubating.jar
>>>>> and it has similar issues.
>>>>>
>>>>> Could you fix it so that these celeborn jars have only one LICENSE and
>>>>> NOTICE file and the LICENSE and NOTICE should acknowledge all the
>>>>> non-Celeborn classes that are bundled?
>>>>>
>>>>> I'd be interested in other people's interpretation here but I think
>>>>> the licensing in the jars is not correct.
>>>>>
>>>>>
>>>>>
>>>>> On Fri, 15 Sept 2023 at 05:03, Cheng Pan <pa...@gmail.com> wrote:
>>>>>>
>>>>>> Hi IPMC,
>>>>>>
>>>>>> This is a call for a vote to release Apache Celeborn (Incubating)
>>>>>> 0.3.1-incubating-rc2
>>>>>>
>>>>>> The Apache Celeborn community has voted on and approved a proposal to
>>>>>> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
>>>>>> We now kindly request the Incubator PMC members review and vote on this
>>>>>> incubator release.
>>>>>>
>>>>>> celeborn@dev vote thread:
>>>>>> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
>>>>>>
>>>>>> celeborn@dev vote result thread:
>>>>>> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
>>>>>>
>>>>>> The git tag to be voted upon:
>>>>>> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
>>>>>>
>>>>>> The git commit hash:
>>>>>> 7ec5596748af49ef9cb429d08550e89d94d5cc74
>>>>>>
>>>>>> The source and binary artifacts can be found at:
>>>>>> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
>>>>>>
>>>>>> The staging repo:
>>>>>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
>>>>>>
>>>>>> Fingerprint of the PGP key release artifacts are signed with:
>>>>>> 8FC8075E1FDC303276C676EE8001952629BCC75D
>>>>>>
>>>>>> My public key to verify signatures can be found in:
>>>>>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>>>>>>
>>>>>> The vote will be open for at least 72 hours or until the necessary
>>>>>> number of votes are reached.
>>>>>>
>>>>>> Please vote accordingly:
>>>>>>
>>>>>> [ ] +1 approve
>>>>>> [ ] +0 no opinion
>>>>>> [ ] -1 disapprove (and the reason)
>>>>>>
>>>>>> Checklist for release:
>>>>>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>>>>>>
>>>>>> Steps to validate the release:
>>>>>> https://www.apache.org/info/verification.html
>>>>>>
>>>>>> Instructions for making binary artifacts from source:
>>>>>> build/make-distribution.sh --release
>>>>>>
>>>>>> Thanks,
>>>>>> Cheng Pan
>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by PJ Fanning <fa...@apache.org>.
I think it would be simpler to use the standard protobuf license. Just
one file, including its copyright.
https://github.com/protocolbuffers/protobuf/blob/main/LICENSE
On Tue, 19 Sept 2023 at 12:45, Cheng Pan <pa...@gmail.com> wrote:
>
> PJ Fanning, both LICENSE-BSD-3.txt and LICENSE-BSD-3.txt are applied to protobuf-java, it was mentioned at the end of client-spark/spark-3-shaded/LICENSE, please let me know if you have a better idea of how to document clearly.
>
>
> > BSD 3-clause
> > See license/LICENSE-BSD-3.txt for details.
> > ------------
> > See license/LICENSE-protobuf.txt for details.
> > com.google.protobuf:protobuf-java
>
> Thanks,
> Cheng Pan
>
>
> > On Sep 19, 2023, at 19:32, PJ Fanning <fa...@apache.org> wrote:
> >
> > I'll have a look around to see if there are other issues.
> >
> > With the BSD license mentioned in the client-spark/spark-3-shaded
> > LICENSE, could it be adjusted to say which libs it applies to?
> >
> > https://github.com/apache/incubator-celeborn/blob/main/client-spark/spark-3-shaded/src/main/resources/META-INF/LICENSE
> >
> > On Tue, 19 Sept 2023 at 12:18, Cheng Pan <pa...@gmail.com> wrote:
> >>
> >> Hi PJ Fanning,
> >>
> >> Thanks for pointing out this issue, it was considered but seems broken recently, unfortunately.
> >>
> >> The proposed NOTICE and LICENSE files are under [1], would you mind taking a look? If it's OK, I’m going to investigate and fix the packaging issue then.
> >>
> >> Given it’s a license issue, I suppose this RC has failed, but it would be nice if you could help to check if other things are OK before starting the next RC.
> >>
> >> [1] https://github.com/apache/incubator-celeborn/tree/main/client-spark/spark-3-shaded/src/main/resources/META-INF
> >>
> >> Thanks,
> >> Cheng Pan
> >>
> >>
> >>> On Sep 19, 2023, at 18:38, PJ Fanning <fa...@apache.org> wrote:
> >>>
> >>> I have some concerns over the jars that are part of the release.
> >>>
> >>> I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in
> >>>
> >>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/
> >>>
> >>> The jar has separate META-INF LICENSE and LICENSE.txt. Likewise for
> >>> NOTICE and NOTICE.txt.
> >>>
> >>> The NOTICE.txt seems to be from Commons Lang.
> >>>
> >>> The jar contains classes from other projects (including non-ASF
> >>> projects like guava) but there appears to be no acknowledgement of
> >>> this in the META-INF LICENSE/NOTICE files.
> >>>
> >>> Example file:
> >>> org/apache/celeborn/shaded/com/google/common/base/Ascii.class
> >>>
> >>> I checked celeborn-client-flink-1.17-shaded_2.12-0.3.1-incubating.jar
> >>> and it has similar issues.
> >>>
> >>> Could you fix it so that these celeborn jars have only one LICENSE and
> >>> NOTICE file and the LICENSE and NOTICE should acknowledge all the
> >>> non-Celeborn classes that are bundled?
> >>>
> >>> I'd be interested in other people's interpretation here but I think
> >>> the licensing in the jars is not correct.
> >>>
> >>>
> >>>
> >>> On Fri, 15 Sept 2023 at 05:03, Cheng Pan <pa...@gmail.com> wrote:
> >>>>
> >>>> Hi IPMC,
> >>>>
> >>>> This is a call for a vote to release Apache Celeborn (Incubating)
> >>>> 0.3.1-incubating-rc2
> >>>>
> >>>> The Apache Celeborn community has voted on and approved a proposal to
> >>>> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
> >>>> We now kindly request the Incubator PMC members review and vote on this
> >>>> incubator release.
> >>>>
> >>>> celeborn@dev vote thread:
> >>>> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
> >>>>
> >>>> celeborn@dev vote result thread:
> >>>> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
> >>>>
> >>>> The git tag to be voted upon:
> >>>> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
> >>>>
> >>>> The git commit hash:
> >>>> 7ec5596748af49ef9cb429d08550e89d94d5cc74
> >>>>
> >>>> The source and binary artifacts can be found at:
> >>>> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
> >>>>
> >>>> The staging repo:
> >>>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
> >>>>
> >>>> Fingerprint of the PGP key release artifacts are signed with:
> >>>> 8FC8075E1FDC303276C676EE8001952629BCC75D
> >>>>
> >>>> My public key to verify signatures can be found in:
> >>>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> >>>>
> >>>> The vote will be open for at least 72 hours or until the necessary
> >>>> number of votes are reached.
> >>>>
> >>>> Please vote accordingly:
> >>>>
> >>>> [ ] +1 approve
> >>>> [ ] +0 no opinion
> >>>> [ ] -1 disapprove (and the reason)
> >>>>
> >>>> Checklist for release:
> >>>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >>>>
> >>>> Steps to validate the release:
> >>>> https://www.apache.org/info/verification.html
> >>>>
> >>>> Instructions for making binary artifacts from source:
> >>>> build/make-distribution.sh --release
> >>>>
> >>>> Thanks,
> >>>> Cheng Pan
> >>>>
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: general-help@incubator.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by Cheng Pan <pa...@gmail.com>.
PJ Fanning, both LICENSE-BSD-3.txt and LICENSE-BSD-3.txt are applied to protobuf-java, it was mentioned at the end of client-spark/spark-3-shaded/LICENSE, please let me know if you have a better idea of how to document clearly.
> BSD 3-clause
> See license/LICENSE-BSD-3.txt for details.
> ------------
> See license/LICENSE-protobuf.txt for details.
> com.google.protobuf:protobuf-java
Thanks,
Cheng Pan
> On Sep 19, 2023, at 19:32, PJ Fanning <fa...@apache.org> wrote:
>
> I'll have a look around to see if there are other issues.
>
> With the BSD license mentioned in the client-spark/spark-3-shaded
> LICENSE, could it be adjusted to say which libs it applies to?
>
> https://github.com/apache/incubator-celeborn/blob/main/client-spark/spark-3-shaded/src/main/resources/META-INF/LICENSE
>
> On Tue, 19 Sept 2023 at 12:18, Cheng Pan <pa...@gmail.com> wrote:
>>
>> Hi PJ Fanning,
>>
>> Thanks for pointing out this issue, it was considered but seems broken recently, unfortunately.
>>
>> The proposed NOTICE and LICENSE files are under [1], would you mind taking a look? If it's OK, I’m going to investigate and fix the packaging issue then.
>>
>> Given it’s a license issue, I suppose this RC has failed, but it would be nice if you could help to check if other things are OK before starting the next RC.
>>
>> [1] https://github.com/apache/incubator-celeborn/tree/main/client-spark/spark-3-shaded/src/main/resources/META-INF
>>
>> Thanks,
>> Cheng Pan
>>
>>
>>> On Sep 19, 2023, at 18:38, PJ Fanning <fa...@apache.org> wrote:
>>>
>>> I have some concerns over the jars that are part of the release.
>>>
>>> I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in
>>>
>>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/
>>>
>>> The jar has separate META-INF LICENSE and LICENSE.txt. Likewise for
>>> NOTICE and NOTICE.txt.
>>>
>>> The NOTICE.txt seems to be from Commons Lang.
>>>
>>> The jar contains classes from other projects (including non-ASF
>>> projects like guava) but there appears to be no acknowledgement of
>>> this in the META-INF LICENSE/NOTICE files.
>>>
>>> Example file:
>>> org/apache/celeborn/shaded/com/google/common/base/Ascii.class
>>>
>>> I checked celeborn-client-flink-1.17-shaded_2.12-0.3.1-incubating.jar
>>> and it has similar issues.
>>>
>>> Could you fix it so that these celeborn jars have only one LICENSE and
>>> NOTICE file and the LICENSE and NOTICE should acknowledge all the
>>> non-Celeborn classes that are bundled?
>>>
>>> I'd be interested in other people's interpretation here but I think
>>> the licensing in the jars is not correct.
>>>
>>>
>>>
>>> On Fri, 15 Sept 2023 at 05:03, Cheng Pan <pa...@gmail.com> wrote:
>>>>
>>>> Hi IPMC,
>>>>
>>>> This is a call for a vote to release Apache Celeborn (Incubating)
>>>> 0.3.1-incubating-rc2
>>>>
>>>> The Apache Celeborn community has voted on and approved a proposal to
>>>> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
>>>> We now kindly request the Incubator PMC members review and vote on this
>>>> incubator release.
>>>>
>>>> celeborn@dev vote thread:
>>>> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
>>>>
>>>> celeborn@dev vote result thread:
>>>> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
>>>>
>>>> The git tag to be voted upon:
>>>> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
>>>>
>>>> The git commit hash:
>>>> 7ec5596748af49ef9cb429d08550e89d94d5cc74
>>>>
>>>> The source and binary artifacts can be found at:
>>>> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
>>>>
>>>> The staging repo:
>>>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
>>>>
>>>> Fingerprint of the PGP key release artifacts are signed with:
>>>> 8FC8075E1FDC303276C676EE8001952629BCC75D
>>>>
>>>> My public key to verify signatures can be found in:
>>>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>>>>
>>>> The vote will be open for at least 72 hours or until the necessary
>>>> number of votes are reached.
>>>>
>>>> Please vote accordingly:
>>>>
>>>> [ ] +1 approve
>>>> [ ] +0 no opinion
>>>> [ ] -1 disapprove (and the reason)
>>>>
>>>> Checklist for release:
>>>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>>>>
>>>> Steps to validate the release:
>>>> https://www.apache.org/info/verification.html
>>>>
>>>> Instructions for making binary artifacts from source:
>>>> build/make-distribution.sh --release
>>>>
>>>> Thanks,
>>>> Cheng Pan
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by PJ Fanning <fa...@apache.org>.
I'll have a look around to see if there are other issues.
With the BSD license mentioned in the client-spark/spark-3-shaded
LICENSE, could it be adjusted to say which libs it applies to?
https://github.com/apache/incubator-celeborn/blob/main/client-spark/spark-3-shaded/src/main/resources/META-INF/LICENSE
On Tue, 19 Sept 2023 at 12:18, Cheng Pan <pa...@gmail.com> wrote:
>
> Hi PJ Fanning,
>
> Thanks for pointing out this issue, it was considered but seems broken recently, unfortunately.
>
> The proposed NOTICE and LICENSE files are under [1], would you mind taking a look? If it's OK, I’m going to investigate and fix the packaging issue then.
>
> Given it’s a license issue, I suppose this RC has failed, but it would be nice if you could help to check if other things are OK before starting the next RC.
>
> [1] https://github.com/apache/incubator-celeborn/tree/main/client-spark/spark-3-shaded/src/main/resources/META-INF
>
> Thanks,
> Cheng Pan
>
>
> > On Sep 19, 2023, at 18:38, PJ Fanning <fa...@apache.org> wrote:
> >
> > I have some concerns over the jars that are part of the release.
> >
> > I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in
> >
> > https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/
> >
> > The jar has separate META-INF LICENSE and LICENSE.txt. Likewise for
> > NOTICE and NOTICE.txt.
> >
> > The NOTICE.txt seems to be from Commons Lang.
> >
> > The jar contains classes from other projects (including non-ASF
> > projects like guava) but there appears to be no acknowledgement of
> > this in the META-INF LICENSE/NOTICE files.
> >
> > Example file:
> > org/apache/celeborn/shaded/com/google/common/base/Ascii.class
> >
> > I checked celeborn-client-flink-1.17-shaded_2.12-0.3.1-incubating.jar
> > and it has similar issues.
> >
> > Could you fix it so that these celeborn jars have only one LICENSE and
> > NOTICE file and the LICENSE and NOTICE should acknowledge all the
> > non-Celeborn classes that are bundled?
> >
> > I'd be interested in other people's interpretation here but I think
> > the licensing in the jars is not correct.
> >
> >
> >
> > On Fri, 15 Sept 2023 at 05:03, Cheng Pan <pa...@gmail.com> wrote:
> >>
> >> Hi IPMC,
> >>
> >> This is a call for a vote to release Apache Celeborn (Incubating)
> >> 0.3.1-incubating-rc2
> >>
> >> The Apache Celeborn community has voted on and approved a proposal to
> >> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
> >> We now kindly request the Incubator PMC members review and vote on this
> >> incubator release.
> >>
> >> celeborn@dev vote thread:
> >> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
> >>
> >> celeborn@dev vote result thread:
> >> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
> >>
> >> The git tag to be voted upon:
> >> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
> >>
> >> The git commit hash:
> >> 7ec5596748af49ef9cb429d08550e89d94d5cc74
> >>
> >> The source and binary artifacts can be found at:
> >> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
> >>
> >> The staging repo:
> >> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
> >>
> >> Fingerprint of the PGP key release artifacts are signed with:
> >> 8FC8075E1FDC303276C676EE8001952629BCC75D
> >>
> >> My public key to verify signatures can be found in:
> >> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> >>
> >> The vote will be open for at least 72 hours or until the necessary
> >> number of votes are reached.
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove (and the reason)
> >>
> >> Checklist for release:
> >> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >>
> >> Steps to validate the release:
> >> https://www.apache.org/info/verification.html
> >>
> >> Instructions for making binary artifacts from source:
> >> build/make-distribution.sh --release
> >>
> >> Thanks,
> >> Cheng Pan
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: general-help@incubator.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by Cheng Pan <pa...@gmail.com>.
Hi PJ Fanning,
Thanks for pointing out this issue, it was considered but seems broken recently, unfortunately.
The proposed NOTICE and LICENSE files are under [1], would you mind taking a look? If it's OK, I’m going to investigate and fix the packaging issue then.
Given it’s a license issue, I suppose this RC has failed, but it would be nice if you could help to check if other things are OK before starting the next RC.
[1] https://github.com/apache/incubator-celeborn/tree/main/client-spark/spark-3-shaded/src/main/resources/META-INF
Thanks,
Cheng Pan
> On Sep 19, 2023, at 18:38, PJ Fanning <fa...@apache.org> wrote:
>
> I have some concerns over the jars that are part of the release.
>
> I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in
>
> https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/
>
> The jar has separate META-INF LICENSE and LICENSE.txt. Likewise for
> NOTICE and NOTICE.txt.
>
> The NOTICE.txt seems to be from Commons Lang.
>
> The jar contains classes from other projects (including non-ASF
> projects like guava) but there appears to be no acknowledgement of
> this in the META-INF LICENSE/NOTICE files.
>
> Example file:
> org/apache/celeborn/shaded/com/google/common/base/Ascii.class
>
> I checked celeborn-client-flink-1.17-shaded_2.12-0.3.1-incubating.jar
> and it has similar issues.
>
> Could you fix it so that these celeborn jars have only one LICENSE and
> NOTICE file and the LICENSE and NOTICE should acknowledge all the
> non-Celeborn classes that are bundled?
>
> I'd be interested in other people's interpretation here but I think
> the licensing in the jars is not correct.
>
>
>
> On Fri, 15 Sept 2023 at 05:03, Cheng Pan <pa...@gmail.com> wrote:
>>
>> Hi IPMC,
>>
>> This is a call for a vote to release Apache Celeborn (Incubating)
>> 0.3.1-incubating-rc2
>>
>> The Apache Celeborn community has voted on and approved a proposal to
>> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
>> We now kindly request the Incubator PMC members review and vote on this
>> incubator release.
>>
>> celeborn@dev vote thread:
>> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
>>
>> celeborn@dev vote result thread:
>> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
>>
>> The git tag to be voted upon:
>> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
>>
>> The git commit hash:
>> 7ec5596748af49ef9cb429d08550e89d94d5cc74
>>
>> The source and binary artifacts can be found at:
>> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
>>
>> The staging repo:
>> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
>>
>> Fingerprint of the PGP key release artifacts are signed with:
>> 8FC8075E1FDC303276C676EE8001952629BCC75D
>>
>> My public key to verify signatures can be found in:
>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>>
>> The vote will be open for at least 72 hours or until the necessary
>> number of votes are reached.
>>
>> Please vote accordingly:
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and the reason)
>>
>> Checklist for release:
>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>>
>> Steps to validate the release:
>> https://www.apache.org/info/verification.html
>>
>> Instructions for making binary artifacts from source:
>> build/make-distribution.sh --release
>>
>> Thanks,
>> Cheng Pan
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2
Posted by PJ Fanning <fa...@apache.org>.
I have some concerns over the jars that are part of the release.
I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in
https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/
The jar has separate META-INF LICENSE and LICENSE.txt. Likewise for
NOTICE and NOTICE.txt.
The NOTICE.txt seems to be from Commons Lang.
The jar contains classes from other projects (including non-ASF
projects like guava) but there appears to be no acknowledgement of
this in the META-INF LICENSE/NOTICE files.
Example file:
org/apache/celeborn/shaded/com/google/common/base/Ascii.class
I checked celeborn-client-flink-1.17-shaded_2.12-0.3.1-incubating.jar
and it has similar issues.
Could you fix it so that these celeborn jars have only one LICENSE and
NOTICE file and the LICENSE and NOTICE should acknowledge all the
non-Celeborn classes that are bundled?
I'd be interested in other people's interpretation here but I think
the licensing in the jars is not correct.
On Fri, 15 Sept 2023 at 05:03, Cheng Pan <pa...@gmail.com> wrote:
>
> Hi IPMC,
>
> This is a call for a vote to release Apache Celeborn (Incubating)
> 0.3.1-incubating-rc2
>
> The Apache Celeborn community has voted on and approved a proposal to
> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2.
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
> celeborn@dev vote thread:
> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv
>
> celeborn@dev vote result thread:
> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9
>
> The git tag to be voted upon:
> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2
>
> The git commit hash:
> 7ec5596748af49ef9cb429d08550e89d94d5cc74
>
> The source and binary artifacts can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapacheceleborn-1039
>
> Fingerprint of the PGP key release artifacts are signed with:
> 8FC8075E1FDC303276C676EE8001952629BCC75D
>
> My public key to verify signatures can be found in:
> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>
> The vote will be open for at least 72 hours or until the necessary
> number of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and the reason)
>
> Checklist for release:
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> Steps to validate the release:
> https://www.apache.org/info/verification.html
>
> Instructions for making binary artifacts from source:
> build/make-distribution.sh --release
>
> Thanks,
> Cheng Pan
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org