You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "szehon-ho (via GitHub)" <gi...@apache.org> on 2023/03/29 22:10:44 UTC
[GitHub] [iceberg] szehon-ho opened a new issue, #7238: Add checks in create/alter table if table location conflicts
szehon-ho opened a new issue, #7238:
URL: https://github.com/apache/iceberg/issues/7238
### Feature Request / Improvement
Currently, when user makes multiple tables point to same location, running removeOrphanFiles on one of them will destroy the data of other tables.
Its a known issue, the the concept of table ownership is discussed at: https://github.com/apache/iceberg/issues/4159. Looks like there are two general directions, either
1. The user does this (to take more advantage of "write.object-storage.enabled", and then has some kind of warehouse-level remove orphan file (not currently in Iceberg OSS project)
2. We don't allow it to go through.
This issue is to achieve the second one. Initial suggestions (can be changed)
- Create/Alter table can check if there's other tables in catalog with same location
- Create/Alter table can check if there's any files in location.
- This behavior can be configured at catalog level (?), in case the first option is achieved above and user does want to put tables in same location.
- We can thus do this check at catalog level (HiveCatalog).
Though its not a perfect fix, it quickly solves an increasing problem, and it matches Trino-side fix, eg: https://github.com/trinodb/trino/pull/12749
### Query engine
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] vamen commented on issue #7238: Add checks in create/alter table if table location conflicts
Posted by "vamen (via GitHub)" <gi...@apache.org>.
vamen commented on issue #7238:
URL: https://github.com/apache/iceberg/issues/7238#issuecomment-1505229911
@karuppayya, have a similar issue. let me know if you have not started. will pick it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Add checks in create/alter table if table location conflicts [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #7238: Add checks in create/alter table if table location conflicts
URL: https://github.com/apache/iceberg/issues/7238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Add checks in create/alter table if table location conflicts [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7238:
URL: https://github.com/apache/iceberg/issues/7238#issuecomment-1858993579
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Add checks in create/alter table if table location conflicts [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7238:
URL: https://github.com/apache/iceberg/issues/7238#issuecomment-1767384670
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] karuppayya commented on issue #7238: Add checks in create/alter table if table location conflicts
Posted by "karuppayya (via GitHub)" <gi...@apache.org>.
karuppayya commented on issue #7238:
URL: https://github.com/apache/iceberg/issues/7238#issuecomment-1491958230
Thanks @szehon-ho for creating this issue, I will try to add some validations in the create/alter and remove orphan files flows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org