You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2023/02/21 10:03:17 UTC

[kudu-CR] KUDU-1945 Auto incrementing column feature flag

Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19523


Change subject: KUDU-1945 Auto incrementing column feature flag
......................................................................

KUDU-1945 Auto incrementing column feature flag

This patch adds the flag "--master_support_auto_incrementing_column" to
guard the auto incrementing column feature. It prohibits users to create
table with non-unique primary key.

Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
---
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/auto_incrementing-itest.cc
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
11 files changed, 77 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/19523/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Yuqi Du, Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19523

to look at the new patch set (#4).

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................

KUDU-1945 Auto-incrementing column feature flag

This patch adds the flag "--master_support_auto_incrementing_column" to
guard the auto-incrementing column feature. It prohibits users to create
table with non-unique primary key. The default value for the flag is set
to true in this patch. The verification happens on the RPC level. If the
server has the feature turned off, or the server is older compared to
the client - doesn't have the auto-incrementing feature -, the request
gets rejected in both cases.

Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
---
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
8 files changed, 64 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/19523/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 2:

(1 comment)

As discussed with Yingchun (RM for the Kudu 1.17), we plan to get this feature completed (including https://gerrit.cloudera.org/#/c/19445/) in a couple of weeks and present in Kudu 1.17. So let's have this enabled by default. If needed we can disable it later on.

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG
Commit Message:

PS2: 
Probably add the details on the behavior with newer client vs older server (which doesn't support the feature).



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 07:42:58 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@122
PS3, Line 122:             "Whether the cluster supports the auto-incrementing column type."
nit: add a space after the period


http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@122
PS3, Line 122: cluster supports the auto-incrementing column type
nit: is that really a type?  Maybe, shorten to something like

... cluster supports auto-incrementing columns



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 06:21:04 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG
Commit Message:

PS2: 
> Probably add the details on the behavior with newer client vs older server 
If I understand correctly, the RPC level verification falls back to rejecting a feature if the flag is not present on the server. (either because it is deliberately turned off, or it is not yet present - older server -)
ServicePool::QueueInboundCall() -> MasterServiceImpl::SupportsFeature()

Added a sentence to the commit message.


http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG@9
PS2, Line 9: This patch adds the flag "--master_support_auto_incrementing_column" to
           : guard the auto-incrementing column feature
> According to your explain at another thread. I think the commit messages ca
Yes initially that would have been better. As of know, the plan is to get the missing patch merged. This would make the feature complete. I think the phrasing is okay this way.


http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG@12
PS2, Line 12: to true in this patch. The verification happens on the RPC level. If the
> nit: Could you mention the default value of the new flag in commit message?
Done


http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@121
PS2, Line 121: master_support_auto_incrementing_column
> 'master_support_auto_incrementing_column'  is added at kudu-master, so 'sup
Yes exactly! Thanks for pointing this out.
Added the tags: experimental, unsafe.

Regarding the naming of the flag: maybe I'm missing something, but all of the other flags are prefixed with 'master', thats why I named the flag in a similar fashion.


http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124
PS2, Line 124: TAG_FLAG(master_support_auto_incrementing_column, unsafe);
> This flag is only for test, right? So we can mark it as 'hidden', maybe 'ru
At this stage yes.
I marked it as 'unsafe', according to the docs, this tag already hides it from user-facing docs.
Regarding the 'runtime' tag, in flag_tags.h it has a big NOTE tag, I did not consider that. So it might not work with the current rev.
Let me know if you think 'runtime' would make sense for this flag, and I will look into it.



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Mar 2023 14:28:39 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 01:14:31 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc@9856
PS2, Line 9856:     FLAGS_master_support_auto_incrementing_column = true;
If set the default value to true, these common tests are not needed to set this flag to true explicitly.


http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@121
PS2, Line 121: DEFINE_bool(master_support_auto_incrementing_column, false,
I'm curious why the default value is false?


http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124
PS2, Line 124: 
This flag is only for test, right? So we can mark it as 'hidden', maybe 'runtime' is needed too?



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 21 Feb 2023 14:55:58 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19523

to look at the new patch set (#2).

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................

KUDU-1945 Auto-incrementing column feature flag

This patch adds the flag "--master_support_auto_incrementing_column" to
guard the auto-incrementing column feature. It prohibits users to create
table with non-unique primary key.

Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
---
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/auto_incrementing-itest.cc
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
11 files changed, 78 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/19523/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124
PS2, Line 124: 
> Of course, it's really runtime (can be changed by CLI tool) even if not mar
+1

It's a runtime flag by the way how it's used.  So, maybe it makes sense adding the 'runtime' tag just to allow for using 'kudu master set_flag' without specifying extra --force option?



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 19:53:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc@9856
PS2, Line 9856:     FLAGS_master_support_auto_incrementing_column = true;
> If set the default value to true, these common tests are not needed to set 
Thanks for jumping in Yingchun!
The deal is that for the auto-incrementing column feature, we still need: https://gerrit.cloudera.org/#/c/19445/ .
However Abhishek is on vacation for a while.
So I figured, I will add the flag to basically disable the auto-incrementing column functionality for now. (not to cause any unwanted issues by default)

I will try to look into the above mentioned patch. But I still need to gather context. 
Once this patch gets merged, I will comment on the release docs, to remove the auto-incrementing column from the release highlights, as it is not fully done/tested yet.



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 21 Feb 2023 15:03:33 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Mar 2023 23:30:39 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................

KUDU-1945 Auto-incrementing column feature flag

This patch adds the flag "--master_support_auto_incrementing_column" to
guard the auto-incrementing column feature. It prohibits users to create
table with non-unique primary key. The default value for the flag is set
to true in this patch. The verification happens on the RPC level. If the
server has the feature turned off, or the server is older compared to
the client - doesn't have the auto-incrementing feature -, the request
gets rejected in both cases.

Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Reviewed-on: http://gerrit.cloudera.org:8080/19523
Tested-by: Kudu Jenkins
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
8 files changed, 64 insertions(+), 5 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Wenzhe Zhou: Looks good to me, but someone else must approve
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc@9856
PS2, Line 9856:     FLAGS_master_support_auto_incrementing_column = true;
> Thanks for jumping in Yingchun!
Abhishek should be back on Monday, so if we can wait until then we can ask him how long it would take to wrap it up and get it through reviews. Then, if it's decided that it would delay the release by too much (it should be your call Yingchun as the RM), then we can merge this to disable it by default.



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 11:35:19 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG@12
PS2, Line 12: 
nit: Could you mention the default value of the new flag in commit message?



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 19:16:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 13:50:42 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Yuqi Du, Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19523

to look at the new patch set (#3).

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................

KUDU-1945 Auto-incrementing column feature flag

This patch adds the flag "--master_support_auto_incrementing_column" to
guard the auto-incrementing column feature. It prohibits users to create
table with non-unique primary key. The default value for the flag is set
to true in this patch. The verification happens on the RPC level. If the
server has the feature turned off, or the server is older compared to
the client - doesn't have the auto-incrementing feature -, the request
gets rejected in both cases.

Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
---
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
8 files changed, 65 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/19523/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124
PS2, Line 124: TAG_FLAG(master_support_auto_incrementing_column, unsafe);
> When upgrade a cluster to the new version which start to support "auto-incr
Of course, it's really runtime (can be changed by CLI tool) even if not mark it.



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 16:11:29 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG@9
PS2, Line 9: This patch adds the flag "--master_support_auto_incrementing_column" to
           : guard the auto-incrementing column feature
> Yes initially that would have been better. As of know, the plan is to get t
Done


http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@121
PS2, Line 121: master_support_auto_incrementing_column
> Yes exactly! Thanks for pointing this out.
ok. no problem.



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 03:21:06 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Mar 2023 01:36:09 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124
PS2, Line 124: TAG_FLAG(master_support_auto_incrementing_column, unsafe);
> +1
Thanks for the notice. Yes, Attila explained this to me as well. Added the runtime tag.


http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124
PS2, Line 124: TAG_FLAG(master_support_auto_incrementing_column, unsafe);
> When upgrade a cluster to the new version which start to support "auto-incr
Ah I see, thank you very much for the explanation!


http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@122
PS3, Line 122: cluster supports auto-incrementing columns. "
> nit: is that really a type?  Maybe, shorten to something like
Done


http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@122
PS3, Line 122:             "Whether the cluster supports auto-incrementing columns. "
> nit: add a space after the period
Done


http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@127
PS3, Line 127: 
> nit: leave one blank line is enough.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Mar 2023 21:28:29 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 3: Code-Review+2

Looks good to me. Let's wait for other reviewers to take a look before merging.


-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 01:06:23 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124
PS2, Line 124: TAG_FLAG(master_support_auto_incrementing_column, unsafe);
> At this stage yes.
When upgrade a cluster to the new version which start to support "auto-incrementing column", we can use rolling upgrade, maybe restart and upgrade Kudu master at first, then Kudu tservers. It may last a long time, say many hours. During this time, if a client send a request to master to create a table with auto-incrementing columns, the master will return success, but will fail (or some other kind of errors) if select a older tserver to create tablet replicas?
In this case, we can set --master_support_auto_incrementing_column as false at the beginning, then set it by CLI tool at runtime without restart master after all tservers restarted.
This is my understanding, although I'm not sure why the other --master_support_* flags are marked as runtime when first introduced.


http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@127
PS3, Line 127: 
nit: leave one blank line is enough.



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 16:08:35 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Auto-incrementing column feature flag

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG@9
PS2, Line 9: This patch adds the flag "--master_support_auto_incrementing_column" to
           : guard the auto-incrementing column feature
According to your explain at another thread. I think the commit messages can be improved by that words.

The patch' purpose is that it's a new feature, and may be unsteady or has bugs to fix, so we need guard it, and turn off it right?


http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@121
PS2, Line 121: master_support_auto_incrementing_column
'master_support_auto_incrementing_column'  is added at kudu-master, so 'support_auto_incrementing_column' is ok?

In fact, the 'auto-incrementing column' function it's a new feature, and we can view it as unsteady to guard it, right?
so we can consider to mark the flag 'master_support_auto_incrementing_column' unsafe and experimental ?



-- 
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 02:50:15 +0000
Gerrit-HasComments: Yes