You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Wesley Tanaka (JIRA)" <ji...@apache.org> on 2017/03/26 08:12:41 UTC

[jira] [Created] (BEAM-1811) Extract common class for WithTimestamps.AddTimestampsDoFn and Create.TimestampedValues.ConvertTimestamps

Wesley Tanaka created BEAM-1811:
-----------------------------------

             Summary: Extract common class for WithTimestamps.AddTimestampsDoFn and Create.TimestampedValues.ConvertTimestamps
                 Key: BEAM-1811
                 URL: https://issues.apache.org/jira/browse/BEAM-1811
             Project: Beam
          Issue Type: Improvement
          Components: beam-model
            Reporter: Wesley Tanaka
            Assignee: Frances Perry
            Priority: Minor


It seems like these APIs are predominantly duplicative of each other and, that it's hard to find one of them if you knew about the other.

https://github.com/apache/beam/blob/348d335883b14a9b143b65e4b3c62dc79f62d77e/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/WithTimestamps.java#L134

https://github.com/apache/beam/blob/348d335883b14a9b143b65e4b3c62dc79f62d77e/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Create.java#L560

What would make the most sense to me is if TimestampedValues were implemented in terms of both Values and WithTimestamps.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)