You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2011/05/27 22:08:47 UTC
[jira] [Created] (SOLR-2552) AbstractSolrTestCase should also
assert that all opened SolrIndexSearchers are closed
AbstractSolrTestCase should also assert that all opened SolrIndexSearchers are closed
-------------------------------------------------------------------------------------
Key: SOLR-2552
URL: https://issues.apache.org/jira/browse/SOLR-2552
Project: Solr
Issue Type: Bug
Reporter: Michael McCandless
Fix For: 3.2, 4.0
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2552) AbstractSolrTestCase should also
assert that all opened SolrIndexSearchers are closed
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved SOLR-2552.
--------------------------------------
Resolution: Fixed
> AbstractSolrTestCase should also assert that all opened SolrIndexSearchers are closed
> -------------------------------------------------------------------------------------
>
> Key: SOLR-2552
> URL: https://issues.apache.org/jira/browse/SOLR-2552
> Project: Solr
> Issue Type: Bug
> Reporter: Michael McCandless
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2552.patch, SOLR-2552.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2552) AbstractSolrTestCase should also
assert that all opened SolrIndexSearchers are closed
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated SOLR-2552:
-------------------------------------
Attachment: SOLR-2552.patch
Patch.
I'll commit soon, and port to trunk too.
> AbstractSolrTestCase should also assert that all opened SolrIndexSearchers are closed
> -------------------------------------------------------------------------------------
>
> Key: SOLR-2552
> URL: https://issues.apache.org/jira/browse/SOLR-2552
> Project: Solr
> Issue Type: Bug
> Reporter: Michael McCandless
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2552.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2552) AbstractSolrTestCase should also
assert that all opened SolrIndexSearchers are closed
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated SOLR-2552:
-------------------------------------
Attachment: SOLR-2552.patch
New patch, also moving the start/endTrackingSearchers to before/afterClass in SolrTestCaseJ4, instead of in init/deleteCore.
> AbstractSolrTestCase should also assert that all opened SolrIndexSearchers are closed
> -------------------------------------------------------------------------------------
>
> Key: SOLR-2552
> URL: https://issues.apache.org/jira/browse/SOLR-2552
> Project: Solr
> Issue Type: Bug
> Reporter: Michael McCandless
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2552.patch, SOLR-2552.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2552) AbstractSolrTestCase should also
assert that all opened SolrIndexSearchers are closed
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040450#comment-13040450 ]
Michael McCandless commented on SOLR-2552:
------------------------------------------
Yes, I believe it was!
In fact there were two separate things -- the first test didn't fail when it should have, and the 2nd test failed to call startTrackingSearchers itself (it inherited the start from the first test).
> AbstractSolrTestCase should also assert that all opened SolrIndexSearchers are closed
> -------------------------------------------------------------------------------------
>
> Key: SOLR-2552
> URL: https://issues.apache.org/jira/browse/SOLR-2552
> Project: Solr
> Issue Type: Bug
> Reporter: Michael McCandless
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2552.patch, SOLR-2552.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2552) AbstractSolrTestCase should also
assert that all opened SolrIndexSearchers are closed
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040444#comment-13040444 ]
Robert Muir commented on SOLR-2552:
-----------------------------------
this looks good, maybe this was causing the test meddling that it didnt happen in before/afterClass?
> AbstractSolrTestCase should also assert that all opened SolrIndexSearchers are closed
> -------------------------------------------------------------------------------------
>
> Key: SOLR-2552
> URL: https://issues.apache.org/jira/browse/SOLR-2552
> Project: Solr
> Issue Type: Bug
> Reporter: Michael McCandless
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2552.patch, SOLR-2552.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org