You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/14 16:04:30 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #16060: [fix][workflow] Support concurrency group and reusable workflow files in docbot

lhotari commented on code in PR #16060:
URL: https://github.com/apache/pulsar/pull/16060#discussion_r897017544


##########
.github/workflows/ci-documentbot.yml:
##########
@@ -27,6 +27,10 @@ on:
       - labeled
       - unlabeled
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true

Review Comment:
   are you sure that in progress builds should be cancelled? That could lead to some events being skipped. it  that fine?



##########
.github/workflows/ci-documentbot.yml:
##########
@@ -27,6 +27,10 @@ on:
       - labeled
       - unlabeled
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true

Review Comment:
   are you sure that in progress builds should be cancelled? That could lead to some events being skipped. is that fine?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org