You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2009/09/14 18:02:54 UTC

svn commit: r814715 - in /hadoop/hbase/branches/0.20: CHANGES.txt src/contrib/transactional/src/java/org/apache/hadoop/hbase/regionserver/tableindexed/IndexedRegion.java src/java/org/apache/hadoop/hbase/client/Result.java

Author: stack
Date: Mon Sep 14 16:02:54 2009
New Revision: 814715

URL: http://svn.apache.org/viewvc?rev=814715&view=rev
Log:
HBASE-1836 test of indexed hbase broken

Modified:
    hadoop/hbase/branches/0.20/CHANGES.txt
    hadoop/hbase/branches/0.20/src/contrib/transactional/src/java/org/apache/hadoop/hbase/regionserver/tableindexed/IndexedRegion.java
    hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/client/Result.java

Modified: hadoop/hbase/branches/0.20/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/CHANGES.txt?rev=814715&r1=814714&r2=814715&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/CHANGES.txt (original)
+++ hadoop/hbase/branches/0.20/CHANGES.txt Mon Sep 14 16:02:54 2009
@@ -9,6 +9,7 @@
    HBASE-1740  ICV has a subtle race condition only visible under high load
    HBASE-1808  [stargate] fix how columns are specified for scanners
    HBASE-1828  CompareFilters are broken from client-side
+   HBASE-1836  test of indexed hbase broken
 
   IMPROVEMENTS
    HBASE-1819  Update to 0.20.1 hadoop and zk 3.2.1

Modified: hadoop/hbase/branches/0.20/src/contrib/transactional/src/java/org/apache/hadoop/hbase/regionserver/tableindexed/IndexedRegion.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/contrib/transactional/src/java/org/apache/hadoop/hbase/regionserver/tableindexed/IndexedRegion.java?rev=814715&r1=814714&r2=814715&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/contrib/transactional/src/java/org/apache/hadoop/hbase/regionserver/tableindexed/IndexedRegion.java (original)
+++ hadoop/hbase/branches/0.20/src/contrib/transactional/src/java/org/apache/hadoop/hbase/regionserver/tableindexed/IndexedRegion.java Mon Sep 14 16:02:54 2009
@@ -260,9 +260,11 @@
     if (result == null || result.raw() == null) {
       return currentColumnValues;
     }
-    
-    for(KeyValue kv : result.list()) {
-      currentColumnValues.put(kv.getColumn(), kv.getValue());
+    List<KeyValue> list = result.list();
+    if (list != null) {
+      for(KeyValue kv : result.list()) {
+        currentColumnValues.put(kv.getColumn(), kv.getValue());
+      }
     }
     return currentColumnValues;
   }

Modified: hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/client/Result.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/client/Result.java?rev=814715&r1=814714&r2=814715&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/client/Result.java (original)
+++ hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/client/Result.java Mon Sep 14 16:02:54 2009
@@ -139,7 +139,7 @@
     if(this.kvs == null) {
       readFields();
     }
-    return Arrays.asList(sorted());
+    return isEmpty()? null: Arrays.asList(sorted());
   }
 
   /**