You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Julien Nioche (JIRA)" <ji...@apache.org> on 2012/10/29 17:00:16 UTC
[jira] [Created] (NUTCH-1482) Rename HTMLParseFilter
Julien Nioche created NUTCH-1482:
------------------------------------
Summary: Rename HTMLParseFilter
Key: NUTCH-1482
URL: https://issues.apache.org/jira/browse/NUTCH-1482
Project: Nutch
Issue Type: Task
Components: parser
Affects Versions: 1.5.1
Reporter: Julien Nioche
See NUTCH-861 for a background discussion. We have changed the name in 2.x to better reflect what it does and I think we should do the same for 1.x.
any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1482) Rename HTMLParseFilter
Posted by "Markus Jelsma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486155#comment-13486155 ]
Markus Jelsma commented on NUTCH-1482:
--------------------------------------
+0 I'm fine with such a change but this will break all (custom) plugins. I am not sure some users will be very happy with this change as all references to it in plugin.xml and the classes must be updated.
> Rename HTMLParseFilter
> ----------------------
>
> Key: NUTCH-1482
> URL: https://issues.apache.org/jira/browse/NUTCH-1482
> Project: Nutch
> Issue Type: Task
> Components: parser
> Affects Versions: 1.5.1
> Reporter: Julien Nioche
>
> See NUTCH-861 for a background discussion. We have changed the name in 2.x to better reflect what it does and I think we should do the same for 1.x.
> any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1482) Rename HTMLParseFilter
Posted by "Sebastian Nagel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486290#comment-13486290 ]
Sebastian Nagel commented on NUTCH-1482:
----------------------------------------
Markus, you are right: I remember the API change of HTMLParseFilter in 1.0: it took me some hours to get the custom plugins compiled.
- is it possible to deprecate the extension point and keep it for some time?
- at least, place a warning in CHANGES.txt with a link to update instructions in the wiki
> Rename HTMLParseFilter
> ----------------------
>
> Key: NUTCH-1482
> URL: https://issues.apache.org/jira/browse/NUTCH-1482
> Project: Nutch
> Issue Type: Task
> Components: parser
> Affects Versions: 1.5.1
> Reporter: Julien Nioche
>
> See NUTCH-861 for a background discussion. We have changed the name in 2.x to better reflect what it does and I think we should do the same for 1.x.
> any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1482) Rename HTMLParseFilter
Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486106#comment-13486106 ]
Lewis John McGibbney commented on NUTCH-1482:
---------------------------------------------
Hi Julien. +1 for this
> Rename HTMLParseFilter
> ----------------------
>
> Key: NUTCH-1482
> URL: https://issues.apache.org/jira/browse/NUTCH-1482
> Project: Nutch
> Issue Type: Task
> Components: parser
> Affects Versions: 1.5.1
> Reporter: Julien Nioche
>
> See NUTCH-861 for a background discussion. We have changed the name in 2.x to better reflect what it does and I think we should do the same for 1.x.
> any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1482) Rename HTMLParseFilter
Posted by "Sebastian Nagel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486144#comment-13486144 ]
Sebastian Nagel commented on NUTCH-1482:
----------------------------------------
+1
> Rename HTMLParseFilter
> ----------------------
>
> Key: NUTCH-1482
> URL: https://issues.apache.org/jira/browse/NUTCH-1482
> Project: Nutch
> Issue Type: Task
> Components: parser
> Affects Versions: 1.5.1
> Reporter: Julien Nioche
>
> See NUTCH-861 for a background discussion. We have changed the name in 2.x to better reflect what it does and I think we should do the same for 1.x.
> any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1482) Rename HTMLParseFilter
Posted by "Julien Nioche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487624#comment-13487624 ]
Julien Nioche commented on NUTCH-1482:
--------------------------------------
Having 2 extension points would be a bit of an overkill IMHO - there aren't any changes in the methods and people just need to do a minor change to the core and xml config which I don't think is unreasonable when moving from one version to the next as long as it is mentioned in the Wiki.
BTW maybe we should organize the CHANGES.txt a bit differently and organise it by type of change (optimisation - bug fix - incompatible change) as done in other projects instead of simply listing the JIRAs
> Rename HTMLParseFilter
> ----------------------
>
> Key: NUTCH-1482
> URL: https://issues.apache.org/jira/browse/NUTCH-1482
> Project: Nutch
> Issue Type: Task
> Components: parser
> Affects Versions: 1.5.1
> Reporter: Julien Nioche
>
> See NUTCH-861 for a background discussion. We have changed the name in 2.x to better reflect what it does and I think we should do the same for 1.x.
> any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira