You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2012/05/10 17:29:00 UTC
svn commit: r1336744 - in
/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak:
core/ContentSessionImpl.java namepath/JcrNameParser.java
spi/state/AbstractNodeState.java
Author: mduerig
Date: Thu May 10 15:29:00 2012
New Revision: 1336744
URL: http://svn.apache.org/viewvc?rev=1336744&view=rev
Log:
- fix Javadoc
- remove unnecessary initialisation
- use for each style loop
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/ContentSessionImpl.java
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/JcrNameParser.java
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/ContentSessionImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/ContentSessionImpl.java?rev=1336744&r1=1336743&r2=1336744&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/ContentSessionImpl.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/ContentSessionImpl.java Thu May 10 15:29:00 2012
@@ -31,7 +31,7 @@ import java.io.IOException;
import java.util.Set;
/**
- * {@link MicroKernel}-based implementation of the {@link ContentSession} interface.
+ * {@code MicroKernel}-based implementation of the {@link ContentSession} interface.
*/
class ContentSessionImpl implements ContentSession {
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/JcrNameParser.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/JcrNameParser.java?rev=1336744&r1=1336743&r2=1336744&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/JcrNameParser.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/JcrNameParser.java Thu May 10 15:29:00 2012
@@ -83,7 +83,7 @@ public class JcrNameParser {
}
// parse the name
- String prefix = "";
+ String prefix;
int nameStart = 0;
int state = STATE_PREFIX_START;
boolean trailingSpaces = false;
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java?rev=1336744&r1=1336743&r2=1336744&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java Thu May 10 15:29:00 2012
@@ -18,7 +18,6 @@ package org.apache.jackrabbit.oak.spi.st
import org.apache.jackrabbit.oak.api.PropertyState;
-import java.util.Iterator;
import java.util.concurrent.atomic.AtomicBoolean;
/**
@@ -68,9 +67,7 @@ public abstract class AbstractNodeState
private static long count(Iterable<?> iterable) {
long n = 0;
- Iterator<?> iterator = iterable.iterator();
- while (iterator.hasNext()) {
- iterator.next();
+ for (Object x : iterable) {
n++;
}
return n;