You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2016/10/28 20:59:02 UTC

[GitHub] storm pull request #1750: STORM-2175: support at least once shutdown in work...

GitHub user revans2 opened a pull request:

    https://github.com/apache/storm/pull/1750

    STORM-2175: support at least once shutdown in worker

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/revans2/incubator-storm STORM-2175-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1750.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1750
    
----
commit ec871d1b9f6ac9f113edbe06eaa32682bd95d5dd
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date:   2016-10-28T20:56:19Z

    STORM-2175: support at least once shutdown in worker

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1750: STORM-2175: fix double close of workers

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1750
  
    @revans2 +1 and I'll take a look at #1749 very soon. Thanks for the great work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1750: STORM-2175: fix double close of workers

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/1750
  
    Tested this with our test set, the issues we were seeing seem fixed. Thank you for looking into this. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1750: STORM-2175: support at least once shutdown in work...

Posted by revans2 <gi...@git.apache.org>.
GitHub user revans2 reopened a pull request:

    https://github.com/apache/storm/pull/1750

    STORM-2175: support at least once shutdown in worker

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/revans2/incubator-storm STORM-2175-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1750.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1750
    
----
commit ec871d1b9f6ac9f113edbe06eaa32682bd95d5dd
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date:   2016-10-28T20:56:19Z

    STORM-2175: support at least once shutdown in worker

commit 9c5d4e41a9d7ec9a02f115abf424374958e245e2
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date:   2016-10-31T16:13:25Z

    STORM-2175: Retry shutdown longer and timeout if too long.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1750: STORM-2175: support at least once shutdown in work...

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 closed the pull request at:

    https://github.com/apache/storm/pull/1750


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1750: STORM-2175: fix double close of workers

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1750


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1750: STORM-2175: fix double close of workers

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/1750
  
    @HeartSaVioR could you take a look at this and #1749 so I can merge this in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1750: STORM-2175: support at least once shutdown in worker

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/1750
  
    Will reopen once I have a better fix that gives more time and throws on a timeout.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---