[GitHub] [incubator-nuttx] zouboan commented on pull request #5472: libdsp:add the calculate of duty now

[GitBox <gi...@apache.org>]

zouboan commented on pull request #5472:
URL: https://github.com/apache/incubator-nuttx/pull/5472#issuecomment-1037268034


   > Hi, I don't think it's a good place for this type of logic. The sensorless observer logic is completely optional and depends on application type. We should avoid the app specific logic in the general libdsp. It's more appropriate to place this code in the apps side and guard additional code with Kconfig option.
   > 
   > Probably [here](https://github.com/apache/incubator-nuttx-apps/blob/master/industry/foc/float/foc_handler.c#L289) for float implementation and add duty_now to `struct foc_handler_output_f32_s`
   > 
   > Or better, export `v_ab_mod` vector in `struct foc_handler_output_f32_s` and calculate duty_now in your observer code. Some observers don't need this variable, so there is no point to introduce it to common code.
   
   the calculate of duty_now has use v_dq_mod vector, if just export `v_ab_mod` vector in `struct foc_handler_output_f32_s` ,a park_transform is needed in other place, is not suitable, how about add v_dq_mod vector in struct foc_data_f32_s and calculate it in foc_voltage_control function?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org