You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2019/04/14 09:07:46 UTC

[maven-scm-publish-plugin] branch master updated: exclude Windows from ITs: require svn and svnadmin executables

This is an automated email from the ASF dual-hosted git repository.

hboutemy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-scm-publish-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 471c7de  exclude Windows from ITs: require svn and svnadmin executables
471c7de is described below

commit 471c7de83b67b50e0fb6f92448eb8f76ccd7f44c
Author: Hervé Boutemy <hb...@apache.org>
AuthorDate: Sun Apr 14 11:07:43 2019 +0200

    exclude Windows from ITs: require svn and svnadmin executables
---
 src/it/publish-scm-staged/invoker.properties | 3 +++
 src/it/publish-scm/invoker.properties        | 3 +++
 src/it/site-deploy/invoker.properties        | 3 +++
 3 files changed, 9 insertions(+)

diff --git a/src/it/publish-scm-staged/invoker.properties b/src/it/publish-scm-staged/invoker.properties
index d5572ef..6af860f 100644
--- a/src/it/publish-scm-staged/invoker.properties
+++ b/src/it/publish-scm-staged/invoker.properties
@@ -16,3 +16,6 @@
 # under the License.
 
 invoker.goals = site site:stage scm-publish:publish-scm
+
+# Windows doesn't have svn and svnadmin executables
+invoker.os.family = !windows
diff --git a/src/it/publish-scm/invoker.properties b/src/it/publish-scm/invoker.properties
index bf59692..eaa8afa 100644
--- a/src/it/publish-scm/invoker.properties
+++ b/src/it/publish-scm/invoker.properties
@@ -16,3 +16,6 @@
 # under the License.
 
 invoker.goals = site scm-publish:publish-scm
+
+# Windows doesn't have svn and svnadmin executables
+invoker.os.family = !windows
diff --git a/src/it/site-deploy/invoker.properties b/src/it/site-deploy/invoker.properties
index 270bcc7..e9b4e5f 100644
--- a/src/it/site-deploy/invoker.properties
+++ b/src/it/site-deploy/invoker.properties
@@ -16,3 +16,6 @@
 # under the License.
 
 invoker.goals = site-deploy
+
+# Windows doesn't have svn and svnadmin executables
+invoker.os.family = !windows


Re: [maven-scm-publish-plugin] branch master updated: exclude Windows from ITs: require svn and svnadmin executables

Posted by Hervé BOUTEMY <he...@free.fr>.
I must confess disabling the IT on Windows is just lazyness to avoid a stupid 
failure on CI

don't hesitate to revert if you really prefer to find and fix the root cause: 
I don't have any problem with job well done by others ;)

Regards,

Hervé

Le dimanche 21 avril 2019, 12:45:12 CEST Robert Scholte a écrit :
> The issue on Jenkins has to do with the @ in the path of the workspace. SCM
> parses this as a username/password separator. Based on the SCM
> Implementation for subversion[1] that's a bug: scm:svn:file:// doesn't
> support username+password
> 
> Robert
> 
> [1] https://maven.apache.org/scm/subversion.html
> [https://maven.apache.org/scm/subversion.html]
> 
> On 14-4-2019 16:12:13, Robert Scholte <rf...@apache.org> wrote:
> Hi Hervé,
> 
> IIRC most of these tests run fine on my Windows machine. Only the one with
> symbolic links has issues, probably because just me running in
> administrator mode to be able to create symlinks. If svn is missing on the
> Windows nodes at builds.a.o, we should ask INFRA to add it, like I did for
> gpg support[1].
> 
> best,
> Robert
> 
> [1] https://issues.apache.org/jira/browse/INFRA-18014
> [https://issues.apache.org/jira/browse/INFRA-18014]
> 
> On 14-4-2019 11:07:53, hboutemy@apache.org <hb...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
> 
> hboutemy pushed a commit to branch master
> in repository
> https://gitbox.apache.org/repos/asf/maven-scm-publish-plugin.git
> 
> 
> The following commit(s) were added to refs/heads/master by this push:
> new 471c7de exclude Windows from ITs: require svn and svnadmin executables
> 471c7de is described below
> 
> commit 471c7de83b67b50e0fb6f92448eb8f76ccd7f44c
> Author: Hervé Boutemy
> AuthorDate: Sun Apr 14 11:07:43 2019 +0200
> 
> exclude Windows from ITs: require svn and svnadmin executables
> ---
> src/it/publish-scm-staged/invoker.properties | 3 +++
> src/it/publish-scm/invoker.properties | 3 +++
> src/it/site-deploy/invoker.properties | 3 +++
> 3 files changed, 9 insertions(+)
> 
> diff --git a/src/it/publish-scm-staged/invoker.properties
> b/src/it/publish-scm-staged/invoker.properties index d5572ef..6af860f
> 100644
> --- a/src/it/publish-scm-staged/invoker.properties
> +++ b/src/it/publish-scm-staged/invoker.properties
> @@ -16,3 +16,6 @@
> # under the License.
> 
> invoker.goals = site site:stage scm-publish:publish-scm
> +
> +# Windows doesn't have svn and svnadmin executables
> +invoker.os.family = !windows
> diff --git a/src/it/publish-scm/invoker.properties
> b/src/it/publish-scm/invoker.properties index bf59692..eaa8afa 100644
> --- a/src/it/publish-scm/invoker.properties
> +++ b/src/it/publish-scm/invoker.properties
> @@ -16,3 +16,6 @@
> # under the License.
> 
> invoker.goals = site scm-publish:publish-scm
> +
> +# Windows doesn't have svn and svnadmin executables
> +invoker.os.family = !windows
> diff --git a/src/it/site-deploy/invoker.properties
> b/src/it/site-deploy/invoker.properties index 270bcc7..e9b4e5f 100644
> --- a/src/it/site-deploy/invoker.properties
> +++ b/src/it/site-deploy/invoker.properties
> @@ -16,3 +16,6 @@
> # under the License.
> 
> invoker.goals = site-deploy
> +
> +# Windows doesn't have svn and svnadmin executables
> +invoker.os.family = !windows





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [maven-scm-publish-plugin] branch master updated: exclude Windows from ITs: require svn and svnadmin executables

Posted by Robert Scholte <rf...@apache.org>.
The issue on Jenkins has to do with the @ in the path of the workspace. SCM parses this as a username/password separator.
Based on the SCM Implementation for subversion[1] that's a bug: scm:svn:file:// doesn't support username+password

Robert

[1] https://maven.apache.org/scm/subversion.html [https://maven.apache.org/scm/subversion.html]

On 14-4-2019 16:12:13, Robert Scholte <rf...@apache.org> wrote:
Hi Hervé,

IIRC most of these tests run fine on my Windows machine. Only the one with symbolic links has issues, probably because just me running in administrator mode to be able to create symlinks.
If svn is missing on the Windows nodes at builds.a.o, we should ask INFRA to add it, like I did for gpg support[1].

best,
Robert

[1] https://issues.apache.org/jira/browse/INFRA-18014 [https://issues.apache.org/jira/browse/INFRA-18014]

On 14-4-2019 11:07:53, hboutemy@apache.org <hb...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.

hboutemy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-scm-publish-plugin.git


The following commit(s) were added to refs/heads/master by this push:
new 471c7de exclude Windows from ITs: require svn and svnadmin executables
471c7de is described below

commit 471c7de83b67b50e0fb6f92448eb8f76ccd7f44c
Author: Hervé Boutemy
AuthorDate: Sun Apr 14 11:07:43 2019 +0200

exclude Windows from ITs: require svn and svnadmin executables
---
src/it/publish-scm-staged/invoker.properties | 3 +++
src/it/publish-scm/invoker.properties | 3 +++
src/it/site-deploy/invoker.properties | 3 +++
3 files changed, 9 insertions(+)

diff --git a/src/it/publish-scm-staged/invoker.properties b/src/it/publish-scm-staged/invoker.properties
index d5572ef..6af860f 100644
--- a/src/it/publish-scm-staged/invoker.properties
+++ b/src/it/publish-scm-staged/invoker.properties
@@ -16,3 +16,6 @@
# under the License.

invoker.goals = site site:stage scm-publish:publish-scm
+
+# Windows doesn't have svn and svnadmin executables
+invoker.os.family = !windows
diff --git a/src/it/publish-scm/invoker.properties b/src/it/publish-scm/invoker.properties
index bf59692..eaa8afa 100644
--- a/src/it/publish-scm/invoker.properties
+++ b/src/it/publish-scm/invoker.properties
@@ -16,3 +16,6 @@
# under the License.

invoker.goals = site scm-publish:publish-scm
+
+# Windows doesn't have svn and svnadmin executables
+invoker.os.family = !windows
diff --git a/src/it/site-deploy/invoker.properties b/src/it/site-deploy/invoker.properties
index 270bcc7..e9b4e5f 100644
--- a/src/it/site-deploy/invoker.properties
+++ b/src/it/site-deploy/invoker.properties
@@ -16,3 +16,6 @@
# under the License.

invoker.goals = site-deploy
+
+# Windows doesn't have svn and svnadmin executables
+invoker.os.family = !windows


Re: [maven-scm-publish-plugin] branch master updated: exclude Windows from ITs: require svn and svnadmin executables

Posted by Robert Scholte <rf...@apache.org>.
Hi Hervé,

IIRC most of these tests run fine on my Windows machine. Only the one with symbolic links has issues, probably because just me running in administrator mode to be able to create symlinks.
If svn is missing on the Windows nodes at builds.a.o, we should ask INFRA to add it, like I did for gpg support[1].

best,
Robert

[1] https://issues.apache.org/jira/browse/INFRA-18014 [https://issues.apache.org/jira/browse/INFRA-18014]

On 14-4-2019 11:07:53, hboutemy@apache.org <hb...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.

hboutemy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-scm-publish-plugin.git


The following commit(s) were added to refs/heads/master by this push:
new 471c7de exclude Windows from ITs: require svn and svnadmin executables
471c7de is described below

commit 471c7de83b67b50e0fb6f92448eb8f76ccd7f44c
Author: Hervé Boutemy
AuthorDate: Sun Apr 14 11:07:43 2019 +0200

exclude Windows from ITs: require svn and svnadmin executables
---
src/it/publish-scm-staged/invoker.properties | 3 +++
src/it/publish-scm/invoker.properties | 3 +++
src/it/site-deploy/invoker.properties | 3 +++
3 files changed, 9 insertions(+)

diff --git a/src/it/publish-scm-staged/invoker.properties b/src/it/publish-scm-staged/invoker.properties
index d5572ef..6af860f 100644
--- a/src/it/publish-scm-staged/invoker.properties
+++ b/src/it/publish-scm-staged/invoker.properties
@@ -16,3 +16,6 @@
# under the License.

invoker.goals = site site:stage scm-publish:publish-scm
+
+# Windows doesn't have svn and svnadmin executables
+invoker.os.family = !windows
diff --git a/src/it/publish-scm/invoker.properties b/src/it/publish-scm/invoker.properties
index bf59692..eaa8afa 100644
--- a/src/it/publish-scm/invoker.properties
+++ b/src/it/publish-scm/invoker.properties
@@ -16,3 +16,6 @@
# under the License.

invoker.goals = site scm-publish:publish-scm
+
+# Windows doesn't have svn and svnadmin executables
+invoker.os.family = !windows
diff --git a/src/it/site-deploy/invoker.properties b/src/it/site-deploy/invoker.properties
index 270bcc7..e9b4e5f 100644
--- a/src/it/site-deploy/invoker.properties
+++ b/src/it/site-deploy/invoker.properties
@@ -16,3 +16,6 @@
# under the License.

invoker.goals = site-deploy
+
+# Windows doesn't have svn and svnadmin executables
+invoker.os.family = !windows