You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Uma Maheswara Rao G (Created) (JIRA)" <ji...@apache.org> on 2011/12/13 19:14:30 UTC
[jira] [Created] (HDFS-2673) While Namenode processing the
blocksBeingWrittenReport, it will log incorrect number blocks count
While Namenode processing the blocksBeingWrittenReport, it will log incorrect number blocks count
-------------------------------------------------------------------------------------------------
Key: HDFS-2673
URL: https://issues.apache.org/jira/browse/HDFS-2673
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 1.0.0
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
Priority: Trivial
In NameNode#blocksBeingWrittenReport
we have the following stateChangeLog
{code}
stateChangeLog.info("*BLOCK* NameNode.blocksBeingWrittenReport: "
+"from "+nodeReg.getName()+" "+blocks.length +" blocks");
{code}
here blocks is long array. Every consecutive 3 elements represents a block ( length, blockid, genstamp).
So, here in log message, blocks.length should be blocks.length/3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2673) While Namenode processing the
blocksBeingWrittenReport, it will log incorrect number blocks count
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170841#comment-13170841 ]
Uma Maheswara Rao G commented on HDFS-2673:
-------------------------------------------
Thanks a lot, Matt for the reviews,
In trunk, there wont be separate blockBeingWritten report. There is one place where we are serialining blocks as long array is blockReport. Here we already handled it.
{code}
+ "from " + nodeReg.getName() + " " + blist.getNumberOfBlocks()
{code}
Thanks
Uma
> While Namenode processing the blocksBeingWrittenReport, it will log incorrect number blocks count
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-2673
> URL: https://issues.apache.org/jira/browse/HDFS-2673
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.0.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Trivial
> Fix For: 1.0.0
>
> Attachments: HDFS-2673.patch
>
>
> In NameNode#blocksBeingWrittenReport
> we have the following stateChangeLog
> {code}
> stateChangeLog.info("*BLOCK* NameNode.blocksBeingWrittenReport: "
> +"from "+nodeReg.getName()+" "+blocks.length +" blocks");
> {code}
> here blocks is long array. Every consecutive 3 elements represents a block ( length, blockid, genstamp).
> So, here in log message, blocks.length should be blocks.length/3.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2673) While Namenode processing the
blocksBeingWrittenReport, it will log incorrect number blocks count
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HDFS-2673:
--------------------------------------
Status: Patch Available (was: Open)
> While Namenode processing the blocksBeingWrittenReport, it will log incorrect number blocks count
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-2673
> URL: https://issues.apache.org/jira/browse/HDFS-2673
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.0.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Trivial
> Attachments: HDFS-2673.patch
>
>
> In NameNode#blocksBeingWrittenReport
> we have the following stateChangeLog
> {code}
> stateChangeLog.info("*BLOCK* NameNode.blocksBeingWrittenReport: "
> +"from "+nodeReg.getName()+" "+blocks.length +" blocks");
> {code}
> here blocks is long array. Every consecutive 3 elements represents a block ( length, blockid, genstamp).
> So, here in log message, blocks.length should be blocks.length/3.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2673) While Namenode processing the
blocksBeingWrittenReport, it will log incorrect number blocks count
Posted by "Matt Foley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-2673:
-----------------------------
Resolution: Fixed
Fix Version/s: 1.0.0
Target Version/s: 1.0.0 (was: 1.1.0)
Status: Resolved (was: Patch Available)
Agree. +1 for code review. Committed to 1.0.0 and branch-1.
Thanks, Uma!
Please check if similar fix is needed in 0.23 and trunk.
> While Namenode processing the blocksBeingWrittenReport, it will log incorrect number blocks count
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-2673
> URL: https://issues.apache.org/jira/browse/HDFS-2673
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.0.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Trivial
> Fix For: 1.0.0
>
> Attachments: HDFS-2673.patch
>
>
> In NameNode#blocksBeingWrittenReport
> we have the following stateChangeLog
> {code}
> stateChangeLog.info("*BLOCK* NameNode.blocksBeingWrittenReport: "
> +"from "+nodeReg.getName()+" "+blocks.length +" blocks");
> {code}
> here blocks is long array. Every consecutive 3 elements represents a block ( length, blockid, genstamp).
> So, here in log message, blocks.length should be blocks.length/3.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2673) While Namenode processing the
blocksBeingWrittenReport, it will log incorrect number blocks count
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HDFS-2673:
--------------------------------------
Attachment: HDFS-2673.patch
Updated patch for 1.1.0 version
> While Namenode processing the blocksBeingWrittenReport, it will log incorrect number blocks count
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-2673
> URL: https://issues.apache.org/jira/browse/HDFS-2673
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.0.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Trivial
> Attachments: HDFS-2673.patch
>
>
> In NameNode#blocksBeingWrittenReport
> we have the following stateChangeLog
> {code}
> stateChangeLog.info("*BLOCK* NameNode.blocksBeingWrittenReport: "
> +"from "+nodeReg.getName()+" "+blocks.length +" blocks");
> {code}
> here blocks is long array. Every consecutive 3 elements represents a block ( length, blockid, genstamp).
> So, here in log message, blocks.length should be blocks.length/3.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2673) While Namenode processing the
blocksBeingWrittenReport, it will log incorrect number blocks count
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169131#comment-13169131 ]
Hadoop QA commented on HDFS-2673:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507227/HDFS-2673.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1712//console
This message is automatically generated.
> While Namenode processing the blocksBeingWrittenReport, it will log incorrect number blocks count
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-2673
> URL: https://issues.apache.org/jira/browse/HDFS-2673
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.0.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Trivial
> Attachments: HDFS-2673.patch
>
>
> In NameNode#blocksBeingWrittenReport
> we have the following stateChangeLog
> {code}
> stateChangeLog.info("*BLOCK* NameNode.blocksBeingWrittenReport: "
> +"from "+nodeReg.getName()+" "+blocks.length +" blocks");
> {code}
> here blocks is long array. Every consecutive 3 elements represents a block ( length, blockid, genstamp).
> So, here in log message, blocks.length should be blocks.length/3.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira