You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2018/10/11 16:49:35 UTC

Review Request 68997: RANGER-2242: JiSQL utility is failing Oracle UDF

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68997/
-----------------------------------------------------------

Review request for ranger, Pradeep Agrawal and Velmurugan Periasamy.


Bugs: RANGER-2242
    https://issues.apache.org/jira/browse/RANGER-2242


Repository: ranger


Description
-------

JiSQL utility fails if SQL patch contains Oracle UDF or stored procedure.


Diffs
-----

  jisql/src/main/java/org/apache/util/sql/Jisql.java 9746a9a09 


Diff: https://reviews.apache.org/r/68997/diff/1/


Testing
-------

Tested with Oracle UDF


Thanks,

Abhay Kulkarni


Re: Review Request 68997: RANGER-2242: JiSQL utility is failing Oracle UDF

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68997/#review209461
-----------------------------------------------------------


Fix it, then Ship it!





jisql/src/main/java/org/apache/util/sql/Jisql.java
Lines 432 (patched)
<https://reviews.apache.org/r/68997/#comment293886>

    Could you please make sure that this is merged into 1.x lines? Thanks.


- Velmurugan Periasamy


On Oct. 11, 2018, 4:49 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68997/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2018, 4:49 p.m.)
> 
> 
> Review request for ranger, Pradeep Agrawal and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2242
>     https://issues.apache.org/jira/browse/RANGER-2242
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> JiSQL utility fails if SQL patch contains Oracle UDF or stored procedure.
> 
> 
> Diffs
> -----
> 
>   jisql/src/main/java/org/apache/util/sql/Jisql.java 9746a9a09 
> 
> 
> Diff: https://reviews.apache.org/r/68997/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with Oracle UDF
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 68997: RANGER-2242: JiSQL utility is failing Oracle UDF

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68997/
-----------------------------------------------------------

(Updated Oct. 11, 2018, 5:43 p.m.)


Review request for ranger, Pradeep Agrawal and Velmurugan Periasamy.


Changes
-------

Updated Apache lines to land the fix


Bugs: RANGER-2242
    https://issues.apache.org/jira/browse/RANGER-2242


Repository: ranger


Description
-------

JiSQL utility fails if SQL patch contains Oracle UDF or stored procedure.


Diffs
-----

  jisql/src/main/java/org/apache/util/sql/Jisql.java 9746a9a09 


Diff: https://reviews.apache.org/r/68997/diff/1/


Testing
-------

Tested with Oracle UDF


Thanks,

Abhay Kulkarni