[GitHub] [ignite] nizhikov commented on a change in pull request #6937: IGNITE-12186 TDE - Phase-2. Master key rotation.

[GitBox <gi...@apache.org>]

nizhikov commented on a change in pull request #6937: IGNITE-12186 TDE - Phase-2. Master key rotation.
URL: https://github.com/apache/ignite/pull/6937#discussion_r338076485
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/encryption/keystore/KeystoreEncryptionSpi.java
 ##########
 @@ -483,19 +469,54 @@ public void setKeySize(int keySize) {
      * Gets master key name.
      *
      * @return Master key name.
+     * @deprecated Use {@link #getMasterKeyId()} instead.
      */
+    @Deprecated
     public String getMasterKeyName() {
-        return masterKeyName;
+        return masterKey.get1();
     }
 
     /**
-     * Sets mater key name.
+     * Sets master key name to use on SPI's start.
      *
      * @param masterKeyName Master key name.
+     * @deprecated Use {@link #setMasterKeyId(String)} instead.
      */
+    @Deprecated
     public void setMasterKeyName(String masterKeyName) {
         assert !started() : "Spi already started";
 
-        this.masterKeyName = masterKeyName;
+        masterKey.set1(masterKeyName);
+    }
+
+    /**
+     * Sets master key.
+     *
+     * @param masterKeyId Master key id.
+     */
+    private void setMasterKey(String masterKeyId) {
 
 Review comment:
   Let's rename it to the `loadMasterKey`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services