You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/12 08:06:13 UTC

[GitHub] [rocketmq-client-go] maqingxiang opened a new issue #711: [bug] The Unsubscribe() interface influence retrytopic

maqingxiang opened a new issue #711:
URL: https://github.com/apache/rocketmq-client-go/issues/711


   BUG REPORT
   
   // push_consumer.go
   
   func (pc *DefaultPushConsumer) Unsubscribe(topic string) error {
       ...
       retryTopic := internal.GetRetryTopic(pc.consumerGroup)
       pc.subscriptionDataTable.Delete(retryTopic)
       ...
   }
   
   There's a scene where the same ConsumerGroup subscries to T1, subscries to T2, and unsubscribe T1. Is that a problem?
   
   the client version is github.com/apache/rocketmq-client-go/v2 v2.1.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] maixiaohai commented on issue #711: [bug] The Unsubscribe() interface influence retrytopic

Posted by GitBox <gi...@apache.org>.
maixiaohai commented on issue #711:
URL: https://github.com/apache/rocketmq-client-go/issues/711#issuecomment-897458107


   @maqingxiang agree with you, welcome to submit a pr to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] francisoliverlee commented on issue #711: [bug] The Unsubscribe() interface influence retrytopic

Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on issue #711:
URL: https://github.com/apache/rocketmq-client-go/issues/711#issuecomment-897860121


   ### as java client does in following files, client no need to Unsubscribe retry topic.
   
   > https://github.com/apache/rocketmq/blob/a20f31bb3de242756542c552d7212a7a40000ba4/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java#L792
   
   > https://github.com/apache/rocketmq/blob/a20f31bb3de242756542c552d7212a7a40000ba4/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java#L932
   
   ## as checked broker codes,  subscribtion for retry topic would never delete. broker update subscribtions on heartbeat:
   > https://github.com/apache/rocketmq/blob/a20f31bb3de242756542c552d7212a7a40000ba4/broker/src/main/java/org/apache/rocketmq/broker/processor/ClientManageProcessor.java#L75


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang closed issue #711: [bug] The Unsubscribe() interface influence retrytopic

Posted by GitBox <gi...@apache.org>.
wenfengwang closed issue #711:
URL: https://github.com/apache/rocketmq-client-go/issues/711


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org