[GitHub] [arrow] liujiacheng777 commented on a diff in pull request #34919: GH-34918: [C++] Update vendored double-conversion

["liujiacheng777 (via GitHub)" <gi...@apache.org>]

liujiacheng777 commented on code in PR #34919:
URL: https://github.com/apache/arrow/pull/34919#discussion_r1161390866


##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -237,12 +237,12 @@ set(ARROW_SRCS
     vendored/base64.cpp
     vendored/datetime/tz.cpp
     vendored/double-conversion/bignum.cc
-    vendored/double-conversion/double-conversion.cc
+    vendored/double-conversion/string-to-double.cc
+    vendored/double-conversion/double-to-string.cc
     vendored/double-conversion/bignum-dtoa.cc
     vendored/double-conversion/fast-dtoa.cc
     vendored/double-conversion/cached-powers.cc
     vendored/double-conversion/fixed-dtoa.cc
-    vendored/double-conversion/diy-fp.cc
     vendored/double-conversion/strtod.cc)

Review Comment:
   Hello, I have sorted alphabetically in the new commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org