[GitHub] [iotdb] wangchao316 commented on a change in pull request #3877: [IOTDB-1600] Support InsertRowsOfOneDevicePlan in cluster

[GitBox <gi...@apache.org>]

wangchao316 commented on a change in pull request #3877:
URL: https://github.com/apache/iotdb/pull/3877#discussion_r700696460



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/query/ClusterPlanRouter.java
##########
@@ -504,4 +507,30 @@ private CreateMultiTimeSeriesPlan createSubPlan(CreateMultiTimeSeriesPlan plan)
     subPlan.setIndexes(new ArrayList<>());
     return subPlan;
   }
+
+  /**
+   * @param plan InsertRowsOfOneDevicePlan
+   * @return key is InsertRowsOfOneDevicePlan, value is the partition group the plan belongs to. All
+   *     InsertRowPlans in InsertRowsOfOneDevicePlan belong to one same storage group.
+   */
+  private Map<PhysicalPlan, PartitionGroup> splitAndRoutePlan(InsertRowsOfOneDevicePlan plan)
+      throws MetadataException {
+    Map<PhysicalPlan, PartitionGroup> result = new HashMap<>();
+    Map<PartitionGroup, List<InsertRowPlan>> groupPlanMap = new HashMap<>();
+    PartialPath storageGroup = getMManager().getStorageGroupPath(plan.getPrefixPath());
+    for (InsertRowPlan p : plan.getRowPlans()) {

Review comment:
       hi , Good Job.
   I have a little...  if you could add some UT or IT, this will validation...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org