You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/12/06 03:59:36 UTC
[kudu-CR] build: enable Java flaky test reporting
Hello Adar Dembo, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12043
to review the following change.
Change subject: build: enable Java flaky test reporting
......................................................................
build: enable Java flaky test reporting
This patch moves flaky test environment setup out of report-test.sh and
into build-and-test.sh so that those environment variables can be
inherited by the Java build environment. That change enables flaky test
reporting for Java tests.
Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
---
M build-support/jenkins/build-and-test.sh
M build-support/report-test.sh
2 files changed, 35 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/12043/1
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] build: enable Java flaky test reporting
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has uploaded a new patch set (#4) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
build: enable Java flaky test reporting
This patch moves flaky test environment setup out of report-test.sh and
into build-and-test.sh so that those environment variables can be
inherited by the Java build environment. That change enables flaky test
reporting for Java tests.
This was tested in a RHEL6 DEBUG build environment. Example:
http://dist-test.cloudera.org:8080/test_drilldown?test_name=testHiveMetastoreIntegration%28org.apache.kudu.test.TestMiniKuduCluster%29
Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
---
M build-support/jenkins/build-and-test.sh
M build-support/report-test.sh
2 files changed, 53 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/12043/4
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] build: enable Java flaky test reporting
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 5
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 16:59:33 +0000
Gerrit-HasComments: No
[kudu-CR] build: enable Java flaky test reporting
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
build: enable Java flaky test reporting
This patch moves flaky test environment setup out of report-test.sh and
into build-and-test.sh so that those environment variables can be
inherited by the Java build environment. That change enables flaky test
reporting for Java tests.
This was tested in a RHEL6 DEBUG build environment. Example:
http://dist-test.cloudera.org:8080/test_drilldown?test_name=testHiveMetastoreIntegration%28org.apache.kudu.test.TestMiniKuduCluster%29
Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Reviewed-on: http://gerrit.cloudera.org:8080/12043
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M build-support/jenkins/build-and-test.sh
M build-support/report-test.sh
2 files changed, 53 insertions(+), 32 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 10
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] build: enable Java flaky test reporting
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 7: Code-Review+2
> > Currently we retry all Java tests in dist_test.py. Should we enable flaky retry functionality like the C++ tests? This could be done in this patch or a follow on.
>
> Yeah potentially, though I need to page back in how we retry on the C++ side. It used to be based on the "list of flaky tests" but has evolved somewhat since.
The premise for not always retrying the C++ tests is the assumption that we should only retry "known flaky" tests, to have a higher chance of catching a commit causing flakiness at code review time. Only nightly runs against master and regular loops on "known flaky" tests contribute to a test's flaky percentage (if it's > 0%)
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 22:53:11 +0000
Gerrit-HasComments: No
[kudu-CR] build: enable Java flaky test reporting
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12043
to look at the new patch set (#2).
Change subject: build: enable Java flaky test reporting
......................................................................
build: enable Java flaky test reporting
This patch moves flaky test environment setup out of report-test.sh and
into build-and-test.sh so that those environment variables can be
inherited by the Java build environment. That change enables flaky test
reporting for Java tests.
This was tested in a RHEL6 DEBUG build environment. Example:
http://dist-test.cloudera.org:8080/test_drilldown?test_name=testHiveMetastoreIntegration%28org.apache.kudu.test.TestMiniKuduCluster%29
Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
---
M build-support/jenkins/build-and-test.sh
M build-support/report-test.sh
2 files changed, 35 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/12043/2
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] build: enable Java flaky test reporting
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 3:
Updating with a rebase on master. No other changes intended.
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 17:30:57 +0000
Gerrit-HasComments: No
[kudu-CR] build: enable Java flaky test reporting
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] build: enable Java flaky test reporting
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 9
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 13:35:54 +0000
Gerrit-HasComments: No
[kudu-CR] build: enable Java flaky test reporting
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 7: Verified+1
(4 comments)
Overriding Jenkins, known flaky test failure.
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/jenkins/build-and-test.sh@244
PS2, Line 244: echo Will retry the flaky tests up to $KUDU_FLAKY_TEST_ATTEMPTS times.
> Should KUDU_REPORT_TEST_RESULTS be documented at the top of the script?
Done
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/jenkins/build-and-test.sh@259
PS2, Line 259: else
: CLANG=$(pwd)/thirdparty/clang-toolchain/bin/clang
: fi
> Now that this is in build-and-test.sh, we can switch on BUILD_TYPE instead
Done
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/report-test.sh
File build-support/report-test.sh:
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/report-test.sh@26
PS2, Line 26: # test result server is down.
> Doc up here what environment variables this script expects to find. Maybe e
Done
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/report-test.sh@30
PS2, Line 30: set -e
> Don't need this anymore.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 20:03:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] build: enable Java flaky test reporting
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 02:30:45 +0000
Gerrit-HasComments: No
[kudu-CR] build: enable Java flaky test reporting
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 8
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 01:41:58 +0000
Gerrit-HasComments: No
[kudu-CR] build: enable Java flaky test reporting
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 8:
> > > Currently we retry all Java tests in dist_test.py. Should we enable flaky retry functionality like the C++ tests? This could be done in this patch or a follow on.
> >
> > Yeah potentially, though I need to page back in how we retry on the C++ side. It used to be based on the "list of flaky tests" but has evolved somewhat since.
>
> The premise for not always retrying the C++ tests is the assumption that we should only retry "known flaky" tests, to have a higher chance of catching a commit causing flakiness at code review time. Only nightly runs against master and regular loops on "known flaky" tests contribute to a test's flaky percentage (if it's > 0%)
I've gone ahead and done this in a follow-on patch. Need to test, then will publish.
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 8
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 04:59:15 +0000
Gerrit-HasComments: No
[kudu-CR] build: enable Java flaky test reporting
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 7:
> Currently we retry all Java tests in dist_test.py. Should we enable flaky retry functionality like the C++ tests? This could be done in this patch or a follow on.
Yeah potentially, though I need to page back in how we retry on the C++ side. It used to be based on the "list of flaky tests" but has evolved somewhat since.
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 20:03:56 +0000
Gerrit-HasComments: No
[kudu-CR] build: enable Java flaky test reporting
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 7: Code-Review+2
Currently we retry all Java tests in dist_test.py. Should we enable flaky retry functionality like the C++ tests? This could be done in this patch or a follow on.
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 14:05:10 +0000
Gerrit-HasComments: No
[kudu-CR] build: enable Java flaky test reporting
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/jenkins/build-and-test.sh@244
PS2, Line 244: if [ -n "$KUDU_REPORT_TEST_RESULTS" ] && [ "$KUDU_REPORT_TEST_RESULTS" -ne 0 ]; then
Should KUDU_REPORT_TEST_RESULTS be documented at the top of the script?
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/jenkins/build-and-test.sh@259
PS2, Line 259: # Parse out our "build config" - a space-separated list of tags
: # which include the cmake build type as well as the list of configured
: # sanitizers.
Now that this is in build-and-test.sh, we can switch on BUILD_TYPE instead of parsing CMakeCache.txt.
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/report-test.sh
File build-support/report-test.sh:
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/report-test.sh@26
PS2, Line 26: # test result server is down.
Doc up here what environment variables this script expects to find. Maybe even test that they exist too.
http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/report-test.sh@30
PS2, Line 30: ROOT=$(dirname $BASH_SOURCE)/..
Don't need this anymore.
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:23:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] build: enable Java flaky test reporting
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 8
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 13:17:32 +0000
Gerrit-HasComments: No