You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org> on 2012/03/01 00:51:57 UTC

[jira] [Commented] (BOOKKEEPER-176) HierarchicalBookieFailureTest Hung

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219666#comment-13219666 ] 

Flavio Junqueira commented on BOOKKEEPER-176:
---------------------------------------------

I'm not really comfortable with the way that we are creating a zoookeeper object in this patch. I was wondering about moving the zookeeper initialization code (in the case the bookkeeper objects owns it) to after construction. One option would be to initialize it in withZKConnected before the call to submit. If the BK objects owns it and is null, we initialize the zookeeper client. I tried this approach, but it turned out not to be very clean, though. It requires more changes than simply moving code.

                
> HierarchicalBookieFailureTest Hung
> ----------------------------------
>
>                 Key: BOOKKEEPER-176
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-176
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-176.diff, BOOKKEEPER-176.diff, HierarchicalBookieFailureTest.jstack.out
>
>
> See jstack attachment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira