[GitHub] [bookkeeper] gaozhangmin commented on a diff in pull request #3600: waitTimeoutOnResponseBackpressureMs should be gt 0

[GitBox <gi...@apache.org>]

gaozhangmin commented on code in PR #3600:
URL: https://github.com/apache/bookkeeper/pull/3600#discussion_r1012452221


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java:
##########
@@ -85,7 +85,7 @@ protected void sendResponse(int rc, Object response, OpStatsLogger statsLogger)
         final long writeNanos = MathUtils.nowInNano();
 
         final long timeOut = requestProcessor.getWaitTimeoutOnBackpressureMillis();
-        if (timeOut >= 0 && !channel.isWritable()) {
+        if (timeOut > 0 && !channel.isWritable()) {

Review Comment:
   Is it ok when timeout is 0 and blacklistedChannels = Optional.empty() ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org