You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/09 09:45:09 UTC

[GitHub] [flink] dawidwys commented on a change in pull request #18645: [FLINK-25745] Document incremental savepoints in CLAIM mode limitation

dawidwys commented on a change in pull request #18645:
URL: https://github.com/apache/flink/pull/18645#discussion_r802467965



##########
File path: docs/content/docs/ops/state/savepoints.md
##########
@@ -269,10 +269,18 @@ the snapshot, while others still depend on it.
   {{< img src="/fig/restore-mode-claim.svg" alt="CLAIM restore mode" width="70%" >}}
 </div>
 
-{{< hint info >}}
-Retained checkpoints are stored in a path like `<checkpoint_dir>/<job_id>/chk_<x>`. Flink does not
+{{< hint warning >}}
+**Attention:**
+1. Retained checkpoints are stored in a path like `<checkpoint_dir>/<job_id>/chk_<x>`. Flink does not
 take ownership of the `<checkpoint_dir>/<job_id>` directory, but only the `chk_<x>`. The directory
 of the old job will not be deleted by Flink
+
+2. [Native](#savepoint-format) format supports incremental RocksDB savepoints. For those savepoints we put all
+SST files inside the savepoints directory. This means such savepoints are self-contained and relocatable.
+However, when restored in CLAIM mode, subsequent checkpoints might reuse some SST files, which
+in turn might block deleting the savepoints directory at the time the savepoint is subsumed. Later
+on we will delete the reused shared SST files, but we won't retry deleting the savepoints directory.
+Therefore, it is possible Flink leaves an empty savepoints directory if it was restored in CLAIM mode.    

Review comment:
       Makes sense, I'll change it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org